[Libreoffice-bugs] [Bug 128540] EPUB tool: some Error and Warning discovered after conversion with a validator

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=128540

--- Comment #14 from David Tardon <dtardon at redhat.com> ---
(In reply to Julien Nabet from comment #13)
> Mark: would it be possible to push this straightforward patch for
> "direction" part?
> diff --git a/src/lib/EPUBBodyStyleManager.cpp
> b/src/lib/EPUBBodyStyleManager.cpp
> index 93d9a5d..bedeb43 100644
> --- a/src/lib/EPUBBodyStyleManager.cpp
> +++ b/src/lib/EPUBBodyStyleManager.cpp
> @@ -26,7 +26,6 @@ void
> EPUBBodyStyleManager::extractProperties(RVNGPropertyList const &pList, EPUB
>      else // For the rest: lr, lr-tb, rl, rl-tb
>      {
>        mode = "horizontal-tb";
> -      cssProps["direction"] = (mode == "rl-tb" || mode == "rl")?"rtl":"ltr";
>      }
>  
>      cssProps["-epub-writing-mode"] = mode;

No. That just removes the symptom without fixing the problem. The CSS property
*should* be removed, but new code should be added that emits (X)HTML dir
attribute. See https://www.w3.org/International/questions/qa-bidi-css-markup
and https://github.com/w3c/epub-specs/issues/335 for more info.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210524/348c020d/attachment.htm>