[Libreoffice-bugs] [Bug 144775] Printing cause read access violation exception
bugzilla-daemon at bugs.documentfoundation.org
bugzilla-daemon at bugs.documentfoundation.org
Sun Oct 3 09:08:11 UTC 2021
https://bugs.documentfoundation.org/show_bug.cgi?id=144775
Mark Hung <marklh9 at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |glogow at fbihome.de
--- Comment #1 from Mark Hung <marklh9 at gmail.com> ---
Hi @jmux
I run a bisect on master branch and traceback to
1b7c53db87bb67eeb2591fbb186f7ac20eb00c68. Maybe this is something you're
working on?
$ git bisect bad
1b7c53db87bb67eeb2591fbb186f7ac20eb00c68 is the first bad commit
commit 1b7c53db87bb67eeb2591fbb186f7ac20eb00c68
Author: Jan-Marek Glogowski <glogow at fbihome.de>
Date: Mon Sep 20 17:55:37 2021 +0200
WIN lazy init WinSalInfoPrinter graphics
... and while at it make stuff private and add _ to the newly
private member variables.
The new assert revealed a bug in the SalGraphics refcounting,
because the virtual ReleaseGraphics is called from the
destructor, which was probably also the reason for the HACK
and comment in Printer::ImplReleaseFonts.
Change-Id: I7af0bda19be6810dd8c0ea5b74604381e2047407
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122371
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow at fbihome.de>
include/vcl/print.hxx | 1 +
vcl/inc/win/salprn.h | 13 ++++++++----
vcl/source/gdi/print.cxx | 15 ++++++-------
vcl/win/gdi/salprn.cxx | 55 +++++++++++++++++++++++++-----------------------
4 files changed, 46 insertions(+), 38 deletions(-)
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20211003/c352433c/attachment-0001.htm>
More information about the Libreoffice-bugs
mailing list