[Libreoffice-bugs] [Bug 144991] EDITING: The "Increase Indent" and "Decrease Indent" increment step should be the width of 3 space chars (using the default style font) when working in an xlsx document

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=144991

Mike Kaganski <mikekaganski at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |erack at redhat.com

--- Comment #1 from Mike Kaganski <mikekaganski at hotmail.com> ---
(In reply to Kevin Suo from comment #0)
> 5. Undo all changes, then change the font size of the Default style to 28pt
> (for both the Western and Asian font in case you have enabled Asian
> language), then save as another xlsx file.
> Expected: the indent for each cell need to be updated to be the new width of
> 3-space chars when the default font family or size is udpated, thus upon
> resave the correct cell indent is exported into xlsx file.

While I agree with #3 and #4 of the proposal, I don't think that #5 is a
reasonable thing to do.

We do not express indents in terms of unnatural units like "default font's
space width". That notation (and other places using same approach, like column
widths represented in max digit width units) is a worst thing that MS could
invent.

It is a reasonable request that when working with Excel file formats, we maybe
adjust our default indent size to what would be saved to the file. But #5
requires more than that: it needs to use "space" unit internally in the
document model.

Alternatively, #5 would require that on change of the default font, all cell
formats are updated to change their indent values proportionally to the space
width change.

I would suggest to limit #5 to this:

5. When default font is changed, the "{In|De}crease Indent" toolbar buttons
should offer the new (updated) increment value - but all current indents in
cells should not be affected.

That would need the change of the default style font to trigger this additional
processing:

1. Check if current document is an Excel file format (check medium);
2. If so, calculate the new space width;
3. Then update SC_INDENT_STEP to be 3*new_space_width.

Eike: what do you think?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20211008/c7eda34e/attachment.htm>