[Libreoffice-bugs] [Bug 144412] Qt5/KF5 flips writing direction on Ctrl+Shift+p

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=144412

Jan-Marek Glogowski <glogow at fbihome.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caolanm at redhat.com

--- Comment #3 from Jan-Marek Glogowski <glogow at fbihome.de> ---
I just thought I could drop the whole nModMask handling for the nExtModMask
info and just use the Qt modifier. But the Qt docs already warn about broken
handling: "This function cannot always be trusted. The user can confuse it by
pressing both Shift keys simultaneously and releasing one of them, for
example." (https://doc.qt.io/qt-5/qkeyevent.html#modifiers). Probably because
Qt reports the combined / new mask on change, but if I just change L/R, it
reports an empty mask.

At this point I'm not sure the whole L/R info should be used. LO's code in qt5
+ gtk + gen has the same problem, because it removes the mask, if one of the
L/R modifier keys is released. So while my patch fixes the problem, I now think
the whole approach is broken; maybe LO should replace it by always reporting
both L/R keys.

I thought the Gtk approach might be good, until I found the behavior in comment
1.

And the Windows code looks funny too.

Looking for more opinions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210909/21386548/attachment.htm>