[Libreoffice-bugs] [Bug 130795] FILEOPEN: Spreadsheet takes long to open

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=130795

--- Comment #25 from Noel Grandin <noelgrandin at gmail.com> ---
(In reply to Luboš Luňák from comment #21)
> The real problem here is not that SharedStringPool would be slow, but that
> ScTable::ValidQuery()/QueryEvaluator calls it at all. If you look at how


The primary call-site in this bug is
   QueryEvaluator:: compareByStringComparator
which is this code:
  
https://opengrok.libreoffice.org/xref/core/sc/source/core/data/table3.cxx?r=0a9b68c9#2687

If I switch that to
    // fallback
    const CharClass& rCharClass = *ScGlobal::getCharClassPtr();
    rtl_uString* pTmpRHS =
const_cast<rtl_uString*>(rItem.maString.getDataIgnoreCase());
    bOk = rCharClass.uppercase(*pValueSource2) ==
OUString::unacquired(&pTmpRHS);

This document takes twice as long to load.

Possibly you had something else in mind?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210913/ef3d0cc4/attachment-0001.htm>