[Libreoffice-bugs] [Bug 144598] Crash in: SkRect::round()

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=144598

Julien Nabet <serval2412 at yahoo.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |heiko.tietze at documentfounda
                   |                            |tion.org,
                   |                            |l.lunak at collabora.com,
                   |                            |xiscofauli at libreoffice.org

--- Comment #5 from Julien Nabet <serval2412 at yahoo.fr> ---
(In reply to Mike Kaganski from comment #3)
> (In reply to Julien Nabet from comment #1)
> 
> Heh, I read there:
> 
> > If there is other or even "UI Render: Skia/Raster" instead, it means the
> > symptoms aren't caused by Skia,
> 
> heh. It is *indeed* wrong. Just yesterday I helped a person over IRC who
> needed the procedure I described in comment 2; and indeed, the problem *was*
> caused by Skia, even though the problem was not using Vulkan (even the
> Skia/Raster was preventing LibreOffice from launch).

With your previous comment, well spotted!
I think we need a quick and easy way to fix this for users instead of modifying
registrymodifications.

Heiko/Xisco/Luboš: Should we create a new entry like 'Disable Skia' or should
we use "Disable hardware acceleration" to set "UseSkia" at False ?

The second option should be straightforward since it only requires 1 extra line
in BackupFileHelper::tryDisableHWAcceleration in
comphelper/source/misc/backupfilehelper.cxx) (see
https://opengrok.libreoffice.org/xref/core/comphelper/source/misc/backupfilehelper.cxx?r=a1252364&mo=64108&fi=1892#1892)

Luboš: I read in vcl/skia/README that "raster" was "CPU-based drawing (here
primarily used for debugging)"
So except debugging for devs, is it necessary to include "raster" Skia in
release versions of LO?
I mean, graphical part is dealt by GPUs or if no GPUs, by chipset included in
motherboards so no use of CPU here too.
So if we remove "raster" case, no need to change registrymodifications
management here, it would be (at least for Windows) either Skia Vulkan or no
Skia at all.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210919/8a293304/attachment.htm>