[Libreoffice-bugs] [Bug 144598] Crash in: SkRect::round()

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=144598

--- Comment #15 from Mike Kaganski <mikekaganski at hotmail.com> ---
(In reply to r2 from comment #0)
> This bug was filed from the crash reporting server and is
> br-2520800e-6840-4482-8a82-b0944a0ad962.

Hm, I should had checked the report first.
The problem is not with GPU. Indeed, it's a CPU illegal instruction, caused by
some wrong instruction set used for building Skia.

FTR: the disassembly of SkRect::round in 7.1.6.2 on Windows x64 official build
is:

> 00007FFC5673B9C0  vmovups     xmm0,xmmword ptr [rcx]  
> 00007FFC5673B9C4  vaddps      xmm0,xmm0,xmmword ptr [__xmm at 3f0000003f0000003f0000003f000000 (07FFC567F05D0h)]  
> 00007FFC5673B9CC  mov         rax,rdx  
> 00007FFC5673B9CF  vroundps    xmm0,xmm0,9  
> 00007FFC5673B9D5  vminps      xmm0,xmm0,xmmword ptr [__xmm at 4effffff4effffff4effffff4effffff (07FFC567EC910h)]  
> 00007FFC5673B9DD  vmaxps      xmm0,xmm0,xmmword ptr [__xmm at ceffffffceffffffceffffffceffffff (07FFC567EC920h)]  
> 00007FFC5673B9E5  vcvttps2dq  xmm0,xmm0  
> 00007FFC5673B9E9  vmovups     xmmword ptr [rdx],xmm0  
> 00007FFC5673B9ED  ret

Note e.g. vroundps, which is specific for AVX, while our baseline for
WindowsX64 is SSE2.

This shows that my idea about the need to disable Skia/Raster is wrong, and
simply the bug around building Skia should be fixed. Or maybe it is already
fixed in a recent 7.2 version?

At least this is how it looks in 7.2.1.2 x64 official build:

> 00007FFC56583110  push        rsi  
> 00007FFC56583111  sub         rsp,60h  
> 00007FFC56583115  movaps      xmmword ptr [rsp+50h],xmm9  
> 00007FFC5658311B  movaps      xmmword ptr [rsp+40h],xmm8  
> 00007FFC56583121  movaps      xmmword ptr [rsp+30h],xmm7  
> 00007FFC56583126  movaps      xmmword ptr [rsp+20h],xmm6  
> 00007FFC5658312B  mov         rsi,rdx  
> 00007FFC5658312E  movups      xmm6,xmmword ptr [rcx]  
> 00007FFC56583131  addps       xmm6,xmmword ptr [__xmm at 3f0000003f0000003f0000003f000000 (07FFC56B5F530h)]  
> 00007FFC56583138  movaps      xmm0,xmm6  
> 00007FFC5658313B  shufps      xmm0,xmm6,0E7h  
> 00007FFC5658313F  call        floorf (07FFC56B58F07h)  
> 00007FFC56583144  movaps      xmm8,xmm0  
> 00007FFC56583148  movaps      xmm0,xmm6  
> 00007FFC5658314B  unpckhpd    xmm0,xmm6  
> 00007FFC5658314F  call        floorf (07FFC56B58F07h)  
> 00007FFC56583154  movaps      xmm9,xmm0  
> 00007FFC56583158  unpcklps    xmm9,xmm8  
> 00007FFC5658315C  movaps      xmm0,xmm6  
> 00007FFC5658315F  call        floorf (07FFC56B58F07h)  
> 00007FFC56583164  movaps      xmm7,xmm0  
> 00007FFC56583167  shufps      xmm6,xmm6,0E5h  
> 00007FFC5658316B  movaps      xmm0,xmm6  
> 00007FFC5658316E  call        floorf (07FFC56B58F07h)  
> 00007FFC56583173  unpcklps    xmm7,xmm0  
> 00007FFC56583176  movlhps     xmm7,xmm9  
> 00007FFC5658317A  minps       xmm7,xmmword ptr [__xmm at 4effffff4effffff4effffff4effffff (07FFC56B5B850h)]  
> 00007FFC56583181  maxps       xmm7,xmmword ptr [__xmm at ceffffffceffffffceffffffceffffff (07FFC56B5B860h)]  
> 00007FFC56583188  cvttps2dq   xmm0,xmm7  
> 00007FFC5658318C  movups      xmmword ptr [rsi],xmm0  
> 00007FFC5658318F  mov         rax,rsi  
> 00007FFC56583192  movaps      xmm6,xmmword ptr [rsp+20h]  
> 00007FFC56583197  movaps      xmm7,xmmword ptr [rsp+30h]  
> 00007FFC5658319C  movaps      xmm8,xmmword ptr [rsp+40h]  
> 00007FFC565831A2  movaps      xmm9,xmmword ptr [rsp+50h]  
> 00007FFC565831A8  add         rsp,60h  
> 00007FFC565831AC  pop         rsi  
> 00007FFC565831AD  ret

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210919/cbfd6907/attachment-0001.htm>