<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Wrong Windows version reported in the About window in Windows 10"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=100233#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Wrong Windows version reported in the About window in Windows 10"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=100233">bug 100233</a>
from <span class="vcard"><a class="email" href="mailto:vstuart.foote@utsa.edu" title="V Stuart Foote <vstuart.foote@utsa.edu>"> <span class="fn">V Stuart Foote</span></a>
</span></b>
<pre>No, we seem to have an implementation problem here with the Windows version
idents [1]. Microsoft deprecated the GetVersionEx() call in current SDKs, but
we've not fully adjusted.
Michael S. tests the generic Windows > Vista with [2][3], and we make the OS
Version query here:
<a href="http://opengrok.libreoffice.org/xref/core/vcl/source/app/svapp.cxx#1173">http://opengrok.libreoffice.org/xref/core/vcl/source/app/svapp.cxx#1173</a>
<a href="http://opengrok.libreoffice.org/xref/core/vcl/win/app/salinst.cxx#1012">http://opengrok.libreoffice.org/xref/core/vcl/win/app/salinst.cxx#1012</a>
Unfortunately, IIUC since our builds remain targeted at Windows XP and do not
manifest for later releases, I think the version returns major 6 minor 2.
Seems that to identify Windows details we probably need to pull major and minor
version ID from OSVERSIONINFO [4], similar to what is being done for OpenGL
support.
<a href="http://opengrok.libreoffice.org/xref/core/vcl/opengl/win/WinDeviceInfo.cxx#185">http://opengrok.libreoffice.org/xref/core/vcl/opengl/win/WinDeviceInfo.cxx#185</a>
For the Help -> About dialog if we want to provide more than major minor and
want to include the build version--we could pull from the OSVERSIONINFOEX
struct [5] rather than OSVERSIONINFO.
Also, there are some legacy calls that probably need to be cleaned up:
<a href="http://opengrok.libreoffice.org/xref/core/vcl/win/app/salinst.cxx?a=true#415">http://opengrok.libreoffice.org/xref/core/vcl/win/app/salinst.cxx?a=true#415</a>
for example where we've hard coded only through Windows 7--with no handling of
8, 8.1 or 10.
=-refs-=
[1] <a href="https://msdn.microsoft.com/en-us/library/ms724832(v=vs.85).aspx">https://msdn.microsoft.com/en-us/library/ms724832(v=vs.85).aspx</a>
[2] <a href="https://msdn.microsoft.com/en-us/library/ms724451(v=vs.85).aspx">https://msdn.microsoft.com/en-us/library/ms724451(v=vs.85).aspx</a>
[3] <a href="https://gerrit.libreoffice.org/#/c/14020/">https://gerrit.libreoffice.org/#/c/14020/</a>
[4] <a href="https://msdn.microsoft.com/en-us/library/ms724834(VS.85).aspx">https://msdn.microsoft.com/en-us/library/ms724834(VS.85).aspx</a>
[5] <a href="https://msdn.microsoft.com/en-us/library/ms724833(v=vs.85).aspx">https://msdn.microsoft.com/en-us/library/ms724833(v=vs.85).aspx</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>