<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:sbergman@redhat.com" title="Stephan Bergmann <sbergman@redhat.com>"> <span class="fn">Stephan Bergmann</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Assertion failed when inserting rectangle shape in spreadsheet"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=108919">bug 108919</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>oliver.specht@cib.de
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Assertion failed when inserting rectangle shape in spreadsheet"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=108919#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Assertion failed when inserting rectangle shape in spreadsheet"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=108919">bug 108919</a>
from <span class="vcard"><a class="email" href="mailto:sbergman@redhat.com" title="Stephan Bergmann <sbergman@redhat.com>"> <span class="fn">Stephan Bergmann</span></a>
</span></b>
<pre>That's interesting. When doing
<<a href="https://cgit.freedesktop.org/libreoffice/core/commit/?id=13bb5a4b09f5b2ad19dad1b55f45d0fe2b2fb908">https://cgit.freedesktop.org/libreoffice/core/commit/?id=13bb5a4b09f5b2ad19dad1b55f45d0fe2b2fb908</a>>
"Make SfxItemSet ranges correct by construction" I naively assumed that an
SfxItemSet's ranges would never include a WID=0, and that therefore the
constructor with a single range,
<span class="quote">> SfxItemSet( SfxItemPool&, sal_uInt16 nWhich1, sal_uInt16 nWhich2 );</span >
should never be called with nWhich1=0 (just as for the multi-range constructor
<span class="quote">> SfxItemSet( SfxItemPool&, int nWh1, int nWh2, int nNull, ... );</span >
an argument of 0 signals end-of-ranges).
However, ever since
<<a href="https://cgit.freedesktop.org/libreoffice/core/commit/?id=71b45e713f2426a70538e2620ee21fa18d82cc89">https://cgit.freedesktop.org/libreoffice/core/commit/?id=71b45e713f2426a70538e2620ee21fa18d82cc89</a>>
"INTEGRATION: CWS pchfix04", FuConstCustomShape::SetAttributes
(sc/source/ui/drawfunc/fuconcustomshape.cxx) creates an SvxAdjustItem with
WID=0, which is then passed into the SfxItemSet constructor as seen in the
backtrace in <span class=""><a href="http://bugs.documentfoundation.org/attachment.cgi?id=134466" name="attach_134466" title="bt with debug symbols (gtk3)">attachment 134466</a> <a href="http://bugs.documentfoundation.org/attachment.cgi?id=134466&action=edit" title="bt with debug symbols (gtk3)">[details]</a></span>.
The other changes from that CWS pchfix04 (see "git log --patch --grep='#i73604#
eeitemid.hxx removed'" and "git log --patch --grep='#i73604# usage of
ITEMID_\* removed'") create SvxAdjustItem instances with RES_PARATR_ADJUST or
EE_PARA_JUST, it appears to be just this one exception with an explicit WID=0.
It is still unclear to me whether SfxItemSet instances containing WID=0 should
e allowed, or whether the change in sc/source/ui/drawfunc/fuconcustomshape.cxx
(done by Oliver) was wrong. Oliver, any thoughts?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>