<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:mstahl@redhat.com" title="Michael Stahl <mstahl@redhat.com>"> <span class="fn">Michael Stahl</span></a>
</span> changed
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - CRASH: Crash after undo operation (BigPtrArray::Index2Block(unsigned long)"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=107975">bug 107975</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>NEW
</td>
<td>RESOLVED
</td>
</tr>
<tr>
<td style="text-align:right;">See Also</td>
<td>
</td>
<td>https://bz.apache.org/ooo/show_bug.cgi?id=97570
</td>
</tr>
<tr>
<td style="text-align:right;">Resolution</td>
<td>---
</td>
<td>FIXED
</td>
</tr>
<tr>
<td style="text-align:right;">Assignee</td>
<td>libreoffice-bugs@lists.freedesktop.org
</td>
<td>mstahl@redhat.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - CRASH: Crash after undo operation (BigPtrArray::Index2Block(unsigned long)"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=107975#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - CRASH: Crash after undo operation (BigPtrArray::Index2Block(unsigned long)"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=107975">bug 107975</a>
from <span class="vcard"><a class="email" href="mailto:mstahl@redhat.com" title="Michael Stahl <mstahl@redhat.com>"> <span class="fn">Michael Stahl</span></a>
</span></b>
<pre>
the commit in <a href="show_bug.cgi?id=107975#c7">comment #7</a> is a good idea but unfortunately incomplete;
there are other places than the one changed there that need to agree
as to whether flys in a selection are deleted or not.
this includes Undo as in this report and OOo issue 97570 (Insert File
instead of Paste) which was incidentally re-introduced by this commit,
as well as redlining.
the Undo currently has difficulties distinguishing between flys
that were already there vs. flys that were inserted by the Paste,
so if it deletes too many flys all the nodes-indexes stored
in Undo objects are off and can cause out-of-bounds indexing.
there is some mechanism in shellio.cxx to track inserted flys;
i forgot if that is used during Paste or not...
unfortunately i'm short on time to investigate how this should work,
so i'll just revert the commit for now, shouldn't crash any more at least.
fixed on master</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>