<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - Demuddle googleApiClient in CommunicationServiceWear (findbugs Medium issue)"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=111393">111393</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>Demuddle googleApiClient in CommunicationServiceWear (findbugs Medium issue)
</td>
</tr>
<tr>
<th>Product</th>
<td>Impress Remote
</td>
</tr>
<tr>
<th>Version</th>
<td>unspecified
</td>
</tr>
<tr>
<th>Hardware</th>
<td>All
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>UNCONFIRMED
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>medium
</td>
</tr>
<tr>
<th>Component</th>
<td>Android app
</td>
</tr>
<tr>
<th>Assignee</th>
<td>libreoffice-bugs@lists.freedesktop.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>andrzej@ahunt.org
</td>
</tr></table>
<p>
<div>
<pre>We have a static GoogleApiClient living in CommunicationServiceWear. However
its actually treated as a member variable (i.e. should be specific to the
instance of CommunicationServiceWear that is being used).
Findbugs rightly complains - I'm planning to suppress that warning for now, but
we should somehow unmuddle this:
<span class="quote">>Write to static field org.libreoffice.impressremote.communication.CommunicationServiceWear.googleApiClient from instance method org.libreoffice.impressremote.communication.CommunicationServiceWear.onCreate()
> Bug type ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD (click for details)
> In class org.libreoffice.impressremote.communication.CommunicationServiceWear
> In method org.libreoffice.impressremote.communication.CommunicationServiceWear.onCreate()
> Field org.libreoffice.impressremote.communication.CommunicationServiceWear.googleApiClient
> At CommunicationServiceWear.java:[line 61]</span >
googleApiClient needs to (at this time) be static since its used by the
(static) presentationPaused()/presentationResumed() implementations. Those in
turn are called by SlideShowActivity. It might be simplest for
SlideShowActivity to simply have its own googleApiClient which it can use to
communicate the pausing/unpausing of the presentation, and then
CommunicationServiceWear can de-staticify its own googleApiClient.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>