<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Small but noticeable lag when selecting shapes with sidebar enabled"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=105500#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Small but noticeable lag when selecting shapes with sidebar enabled"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=105500">bug 105500</a>
from <span class="vcard"><a class="email" href="mailto:j.nitschke+tdfbz@ok.de" title="JoNi <j.nitschke+tdfbz@ok.de>"> <span class="fn">JoNi</span></a>
</span></b>
<pre>(In reply to Commit Notification from <a href="show_bug.cgi?id=105500#c13">comment #13</a>)
<span class="quote">> Julien Nabet committed a patch related to this issue.
> It has been pushed to "master":
>
> <a href="http://cgit.freedesktop.org/libreoffice/core/commit/">http://cgit.freedesktop.org/libreoffice/core/commit/</a>
> ?id=8c0cc5cd7befffc6e8e6361ba67807a799cc997f
>
> Related tdf#105500: leaks in PaletteManager and SvxColorToolBoxControl</span >
I doubt this patch does anything.
~SvxColorToolBoxControl destructs all it's members including m_xPaletteManager.
The unique_ptr<PaletteManager> destructor calls destructor of the
PaletteManager object.
~PaletteManager destructs all it's members too. This includes the vector
m_Palettes. A vector destructor calls the destructor for all objects it holds
(clear() does the same). So finally the unique_ptr<Pallette> destructors
release all the Palette objects.
We don't have to worry about reset, clear, delete or anything.
That said, I don't see any obvious leaks. But I got no idea how to interpret
<span class=""><a href="http://bugs.documentfoundation.org/attachment.cgi?id=135607" name="attach_135607" title="Memory leak profile">attachment 135607</a> <a href="http://bugs.documentfoundation.org/attachment.cgi?id=135607&action=edit" title="Memory leak profile">[details]</a></span>, looks like it's only listing allocations.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>