<html>
    <head>
      <base href="https://bugs.documentfoundation.org/">
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_UNCONFIRMED "
   title="UNCONFIRMED - Improve the workflow of adding items to menus"
   href="https://bugs.documentfoundation.org/show_bug.cgi?id=112369">112369</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>Improve the workflow of adding items to menus
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>LibreOffice
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>6.0.0.0.alpha0+ Master
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>All
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>All
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>UNCONFIRMED
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>normal
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>medium
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>UI
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>libreoffice-bugs@lists.freedesktop.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>muhammet.kara@pardus.org.tr
          </td>
        </tr></table>
      <p>
        <div>
        <pre>This is a spin off from
<a class="bz_bug_link 
          bz_status_ASSIGNED "
   title="ASSIGNED - Polishing the visual appearance"
   href="show_bug.cgi?id=112133">https://bugs.documentfoundation.org/show_bug.cgi?id=112133</a>

 Muhammet Kara 2017-09-13 10:09:37 UTC
(In reply to Heiko Tietze from <a href="show_bug.cgi?id=112369#c12">comment #12</a>)
<span class="quote">> When adding a command to a menu or context menu that already contains this
> items a confirmation box is shown telling the user that this operation is
> not possible. Not the best approach, and you better disable the add button.</span >

This requires some more dev effort than the polishing task itself requires.
Let's separate it.

Instead of checking for duplicates after pressing the add button, we may check
for duplicates in SvxMenuConfigPage::UpdateButtonStates(), and make sure it is
called from both SelectMenu and SelectFunctionHdl.

Note that SelectMenu is in SvxMenuConfigConfigPage, while SelectFunctionHdl is
in SvxConfigPage. So it might be a good idea to move one of them to the parent
or to the child class.</pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>