<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:baron@caesar.elte.hu" title="Aron Budea <baron@caesar.elte.hu>"> <span class="fn">Aron Budea</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [META] Bugs caused/worsened by using DirectWrite more"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=112486">bug 112486</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>khaledhosny@eglug.org
</td>
</tr>
<tr>
<td style="text-align:right;">Blocks</td>
<td>
</td>
<td>109234
</td>
</tr>
<tr>
<td style="text-align:right;">Summary</td>
<td>[META] Bugs caused/worsened by forcing GDI when needed
</td>
<td>[META] Bugs caused/worsened by using DirectWrite more
</td>
</tr>
<tr>
<td style="text-align:right;">Alias</td>
<td>Regressions-forcing-GDI
</td>
<td>Regressions-from-more-DWrite
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [META] Bugs caused/worsened by using DirectWrite more"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=112486#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [META] Bugs caused/worsened by using DirectWrite more"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=112486">bug 112486</a>
from <span class="vcard"><a class="email" href="mailto:baron@caesar.elte.hu" title="Aron Budea <baron@caesar.elte.hu>"> <span class="fn">Aron Budea</span></a>
</span></b>
<pre>Let's point to Khaled's analysis (thanks for that):
"Hmm, I don’t think you need to revert the whole change. Looking into
this again, I think there are two unrelated changes in this commit;
forcing GDI for non-horizontal text which fixed the two bugs, and
optionally not using GDI when not using OpenGL (previously we always
used GDI when OpenGL was used). I think it was wishful thinking of my
part to think the non-GDI code path is usable.
In short, I guess you just need to change the !bUseOpenGL branch back to:
DrawTextLayout(rLayout, hDC, false);
This should fix the newly introduced issues. I can’t test this myself
right now, though, and might not be able to do so for few more weeks.
It might also cause a regression for some Graphite fonts, but I
don’t remember the details, but it shouldn’t be hard to have a
CommonSalLayout::isGraphite() or so to signal such fonts and not use
GDI for them."
<a href="http://nabble.documentfoundation.org/Re-Minutes-of-ESC-call-2017-09-21-tt4223238.html#a4223433">http://nabble.documentfoundation.org/Re-Minutes-of-ESC-call-2017-09-21-tt4223238.html#a4223433</a></pre>
</div>
</p>
<div id="referenced">
<hr style="border: 1px dashed #969696">
<b>Referenced Bugs:</b>
<ul>
<li>
[<a class="bz_bug_link
bz_status_NEW "
title="NEW - [META] DirectWrite rendering bugs and enhancements"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=109234">Bug 109234</a>] [META] DirectWrite rendering bugs and enhancements
</li>
</ul>
</div>
<br>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>