<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:xiscofauli@libreoffice.org" title="Xisco Faulí <xiscofauli@libreoffice.org>"> <span class="fn">Xisco Faulí</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - export to pdf wrong results"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=114384">bug 114384</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Keywords</td>
<td>
</td>
<td>bibisected, bisected, regression
</td>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>UNCONFIRMED
</td>
<td>NEW
</td>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>quikee@gmail.com, xiscofauli@libreoffice.org
</td>
</tr>
<tr>
<td style="text-align:right;">Ever confirmed</td>
<td>
</td>
<td>1
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - export to pdf wrong results"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=114384#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - export to pdf wrong results"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=114384">bug 114384</a>
from <span class="vcard"><a class="email" href="mailto:xiscofauli@libreoffice.org" title="Xisco Faulí <xiscofauli@libreoffice.org>"> <span class="fn">Xisco Faulí</span></a>
</span></b>
<pre>Regression introduced by:
author Tomaž Vajngerl <<a href="mailto:tomaz.vajngerl@collabora.co.uk">tomaz.vajngerl@collabora.co.uk</a>> 2017-12-02 01:17:15
+0900
committer Tomaž Vajngerl <<a href="mailto:quikee@gmail.com">quikee@gmail.com</a>> 2017-12-04 08:07:24
+0100
commit 5684e53b931eaaac658bc3246ae1c3249e252fdb (patch)
tree 68163cd76212a5367c115a959f0602e41e88f6c2
parent 75702b13961e545809ce1f2b5a45787f42ffcbc6 (diff)
Calculate print page ranges only when needed, cache in print state
When printing or exporting PDF, we need to calculate the page
print (cell) ranges for the current zoom level (document size).
This is quite a expensive thing to do as you need to inspect
the properties of individual cells.
The calculation ideally needs to be done only once per printing
request, but because of the rendering UNO API, this was done
everytime ScPrintFunc was instantiated, which is for every page
twice (once getRenderer is called and then when render is called).
To fix this performance issue, the print page ranges need to be
carried from one call to ScPrintFunc to the other. There already
is a print state (ScPrintState) which is used for exactly that,
but it didn't do this for print page ranges.
With this, PDF export time in a test case decreased from 17 sec to
around 3 sec.
Bisected with: bibisect-linux64-6.1
Adding Cc: to Tomaž Vajngerl</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>