<html> <head> <base href="https://bugs.documentfoundation.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - EDITING: Table loses formatting when inserting a new row in a table" href="https://bugs.documentfoundation.org/show_bug.cgi?id=115573#c36">Comment # 36</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - EDITING: Table loses formatting when inserting a new row in a table" href="https://bugs.documentfoundation.org/show_bug.cgi?id=115573">bug 115573</a> from <a class="email" href="mailto:raykowj@gmail.com" title="Jim Raykowski <raykowj@gmail.com>"> Jim Raykowski</a> <pre>(In reply to Aron Budea from <a href="show_bug.cgi?id=115573#c35">comment #35</a>) > Jim, in [1] the conclusion is that the patches for <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - Table style is not highlighted in Stylist (F11 Right SideBar)" href="show_bug.cgi?id=108227">bug 108227</a> and <a class="bz_bug_link bz_status_RESOLVED bz_closed" title="RESOLVED FIXED - Apply the 'Default Style' table style to newly inserted tables" href="show_bug.cgi?id=107555">bug 107555</a> > need to be reverted for now, can you please give an update on that? > > [1] <a href="https://gerrit.libreoffice.org/#/c/49831/">https://gerrit.libreoffice.org/#/c/49831/</a> Hi Aron, Yes these patches should be reverted for now. I believe both are good ideas but need to wait until autoformat and user direct formatting of tables can be made to work well together. I have thought of two ways this can be accomplished and have had some success with both: 1. When direct formatting is made to a table then the table's autoformat style is no longer used. This results in no table style highlighted in the sidebar styles table styles panel after a direct format is made. Autoformatting is no longer applied to the table afer row/column additions/deletions so that direct formatting is preserved. 2. The table retains the autoformat style for table boxes (cells) that do not have direct formatting by the user. This results in the sidebar style table style remaining highlighted after user direct formatting. When rows/columns are inserted/removed direct formatted cells are untouched by autoformatting. The table follows autoformatting style on inserts/removes. Background color position dependency is one advantage I can see with this approach. When insertions or deletions are made the row or column background color still follows the autoformat style. Approach 1 may be easier to implement. I have made some progress on approach 2 where table boxes keep their direct formatting of borders, line styles, number formatting, and background color, after insertion/deletions. Working on font retention. Insertions and deletions are made with autoformat style so the table keeps the autoformat style for table boxes that are not direct formatted. Other ideas are welcome. What is the best way to do the revert? I will do a revert patch if needed.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>