<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:michael.meeks@collabora.com" title="Michael Meeks <michael.meeks@collabora.com>"> <span class="fn">Michael Meeks</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - crashtesting ooo24656-1.doc with --convert-to pdf"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=118029">bug 118029</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>Armin.Le.Grand@me.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - crashtesting ooo24656-1.doc with --convert-to pdf"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=118029#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - crashtesting ooo24656-1.doc with --convert-to pdf"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=118029">bug 118029</a>
from <span class="vcard"><a class="email" href="mailto:michael.meeks@collabora.com" title="Michael Meeks <michael.meeks@collabora.com>"> <span class="fn">Michael Meeks</span></a>
</span></b>
<pre>Oh - wow ...
#13 0x00007fffef03fb0b in Bitmap::ReleaseAccess (pBitmapAccess=0x7fffb00010b0)
at /home/noel/libo/vcl/source/bitmap/bitmap.cxx:389
#14 0x00007fffeecde94a in vcl::ScopedBitmapAccess<BitmapReadAccess, Bitmap,
&Bitmap::AcquireReadAccess>::~ScopedBitmapAccess (this=0x7fffbfb8ba50)
at /home/noel/libo/include/vcl/scopedbitmapaccess.hxx:85
#15 0x00007fffeed64c42 in BitmapEx::GetPixelColor (this=0x7fffb00015e8, nX=116,
nY=48) at /home/noel/libo/vcl/source/gdi/bitmapex.cxx:759
#16 0x00007fffe8d1bf92 in
drawinglayer::texture::GeoTexSvxBitmapEx::modifyBColor (this=0x7fffb00015e0,
rUV=..., rBColor=..., rfOpacity=@0x7fffbfb8bd30: 1)
at /home/noel/libo/drawinglayer/source/texture/texture3d.cxx:125
#17 0x00007fffe8d1c848 in
Looks like a disaster not just from a threading perspective - but a performance
perspective too =) Creating and destroying this guy:
Bitmap::ScopedReadAccess pReadAccess( aTestBitmap );
per-pixel can (IIRC) result in a DMA directly to GPU memory and all sorts of
horrible slowness (I forget if we cache on the CPU the copy we get back there).
Either way - that looks really 'orrible.
I'm rather surprised that we're threading the Bitmap access in the first
instance TBH - and then doing manual pixel bashing serially on the CPU while
threaded rather than in a shader in unbelievable parallel (hundreds wide) on
the GPU - is also a curious choice but ... ;-)
It is far from clear to me that doing tons of atomic references and making
'mapmode thread safe' ;-) [ if that is even the plan ] is the right way to do
threading; sounds impossibly granular to me =)
So - what gives ? this looks quite far from ideal to me =)</pre>
</div>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - crashtesting ooo24656-1.doc with --convert-to pdf"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=118029#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - crashtesting ooo24656-1.doc with --convert-to pdf"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=118029">bug 118029</a>
from <span class="vcard"><a class="email" href="mailto:michael.meeks@collabora.com" title="Michael Meeks <michael.meeks@collabora.com>"> <span class="fn">Michael Meeks</span></a>
</span></b>
<pre>Oh - wow ...
#13 0x00007fffef03fb0b in Bitmap::ReleaseAccess (pBitmapAccess=0x7fffb00010b0)
at /home/noel/libo/vcl/source/bitmap/bitmap.cxx:389
#14 0x00007fffeecde94a in vcl::ScopedBitmapAccess<BitmapReadAccess, Bitmap,
&Bitmap::AcquireReadAccess>::~ScopedBitmapAccess (this=0x7fffbfb8ba50)
at /home/noel/libo/include/vcl/scopedbitmapaccess.hxx:85
#15 0x00007fffeed64c42 in BitmapEx::GetPixelColor (this=0x7fffb00015e8, nX=116,
nY=48) at /home/noel/libo/vcl/source/gdi/bitmapex.cxx:759
#16 0x00007fffe8d1bf92 in
drawinglayer::texture::GeoTexSvxBitmapEx::modifyBColor (this=0x7fffb00015e0,
rUV=..., rBColor=..., rfOpacity=@0x7fffbfb8bd30: 1)
at /home/noel/libo/drawinglayer/source/texture/texture3d.cxx:125
#17 0x00007fffe8d1c848 in
Looks like a disaster not just from a threading perspective - but a performance
perspective too =) Creating and destroying this guy:
Bitmap::ScopedReadAccess pReadAccess( aTestBitmap );
per-pixel can (IIRC) result in a DMA directly to GPU memory and all sorts of
horrible slowness (I forget if we cache on the CPU the copy we get back there).
Either way - that looks really 'orrible.
I'm rather surprised that we're threading the Bitmap access in the first
instance TBH - and then doing manual pixel bashing serially on the CPU while
threaded rather than in a shader in unbelievable parallel (hundreds wide) on
the GPU - is also a curious choice but ... ;-)
It is far from clear to me that doing tons of atomic references and making
'mapmode thread safe' ;-) [ if that is even the plan ] is the right way to do
threading; sounds impossibly granular to me =)
So - what gives ? this looks quite far from ideal to me =)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>