<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:serval2412@yahoo.fr" title="Julien Nabet <serval2412@yahoo.fr>"> <span class="fn">Julien Nabet</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Gridlines "Show on colored cells" not working"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=118295">bug 118295</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>serval2412@yahoo.fr
</td>
</tr>
<tr>
<td style="text-align:right;">Ever confirmed</td>
<td>
</td>
<td>1
</td>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>UNCONFIRMED
</td>
<td>NEW
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Gridlines "Show on colored cells" not working"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=118295#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Gridlines "Show on colored cells" not working"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=118295">bug 118295</a>
from <span class="vcard"><a class="email" href="mailto:serval2412@yahoo.fr" title="Julien Nabet <serval2412@yahoo.fr>"> <span class="fn">Julien Nabet</span></a>
</span></b>
<pre>On pc Debian x86-64 with master sources updated today, I could reproduce this.
I noticed that this option was used with vars or const like:
- bGridOnTop
- VOPT_GRID_ONTOP
318 IMPL_LINK( ScTpContentOptions, GridHdl, ListBox&, rLb, void )
319 {
320 sal_Int32 nSelPos = rLb.GetSelectedEntryPos();
321 bool bGrid = ( nSelPos <= 1 );
322 bool bGridOnTop = ( nSelPos == 1 );
323
324 pColorFT->Enable(bGrid);
325 pColorLB->Enable(bGrid);
326 pLocalOptions->SetOption( VOPT_GRID, bGrid );
327 pLocalOptions->SetOption( VOPT_GRID_ONTOP, bGridOnTop );
328 }
=>
Show : value 0, bGrid = true, bGridOnTop = false
Show on colored cells : value 1, bGrid = true, bGridOnTop = true
Hide : value 2, bGrid = false, bGridOnTop = false
See
<a href="https://opengrok.libreoffice.org/xref/core/sc/source/ui/optdlg/tpview.cxx#318">https://opengrok.libreoffice.org/xref/core/sc/source/ui/optdlg/tpview.cxx#318</a>
Again the same mix (grid on color/grid on top):
498 case SCLAYOUTOPT_GRID_ONCOLOR:
499 pValues[nProp] <<= GetOption( VOPT_GRID_ONTOP );
500 break;
<a href="https://opengrok.libreoffice.org/xref/core/sc/source/core/tool/viewopti.cxx#498">https://opengrok.libreoffice.org/xref/core/sc/source/core/tool/viewopti.cxx#498</a>
Finally the value is used in sc/source/ui/view/gridwin4.cxx:
557 bool bGridFirst = !rOpts.GetOption( VOPT_GRID_ONTOP );
...
715 if ( bGridFirst && ( bGrid || bPage ) )
716 aOutputData.DrawGrid(*pContentDev, bGrid, bPage);
717
718 aOutputData.DrawBackground(*pContentDev);
719
720 if ( !bGridFirst && ( bGrid || bPage ) )
721 aOutputData.DrawGrid(*pContentDev, bGrid, bPage);
See
<a href="https://opengrok.libreoffice.org/xref/core/sc/source/ui/view/gridwin4.cxx#715">https://opengrok.libreoffice.org/xref/core/sc/source/ui/view/gridwin4.cxx#715</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>