<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - Master background settings not preserved if changed from the sidebar"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=119691">119691</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>Master background settings not preserved if changed from the sidebar
</td>
</tr>
<tr>
<th>Product</th>
<td>LibreOffice
</td>
</tr>
<tr>
<th>Version</th>
<td>5.3 all versions
</td>
</tr>
<tr>
<th>Hardware</th>
<td>All
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>UNCONFIRMED
</td>
</tr>
<tr>
<th>Severity</th>
<td>enhancement
</td>
</tr>
<tr>
<th>Priority</th>
<td>medium
</td>
</tr>
<tr>
<th>Component</th>
<td>Impress
</td>
</tr>
<tr>
<th>Assignee</th>
<td>libreoffice-bugs@lists.freedesktop.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>xiscofauli@libreoffice.org
</td>
</tr></table>
<p>
<div>
<pre>This is a follow-up bug of <a class="bz_bug_link
bz_status_NEW "
title="NEW - EDITING: The master slide loses the background when changing page format of orientation using the sidebar"
href="show_bug.cgi?id=111306">bug 111306</a>.
in
<a href="https://cgit.freedesktop.org/libreoffice/core/commit/?id=64ff7453408e578b95073db1740bfef4f500a2e4">https://cgit.freedesktop.org/libreoffice/core/commit/?id=64ff7453408e578b95073db1740bfef4f500a2e4</a>,
the master slide background was added to the sidebar, however, the changes done
in the sidebar are not applied to the document and thus, the changes are lost
after some other changes or RT, for instance:
1. Open Impress
2. View -> Slide Master
3. Select a background in the sidebar
4. Change the orientation to Portrait
-> The background setting will be undone
or
1.Create slide(s) in impress.
2.Open master slide view and change background colour to black. It is observed
that the background colour changes to black and fonts to white, as intended.
3.Close master slide view. It is observed that the new settings have been
implemented in all slides.
4.Save the presentation in pptx format.
5.Close the window.
6.Open file again with libreoffice.
Due to the number of reports we got since
64ff7453408e578b95073db1740bfef4f500a2e4 I decided to hide the widget in the
sidebar in
<a href="https://cgit.freedesktop.org/libreoffice/core/commit/?id=c57f10b67fceef47d304d74dce93be7389a7720c">https://cgit.freedesktop.org/libreoffice/core/commit/?id=c57f10b67fceef47d304d74dce93be7389a7720c</a>
as a temporal fix to avoid confusion, however, the root cause should be fix at
some point.
Note that the master background can still be changed from the page properties
dialog.
Some info:
The code related to the slide properties dialog is in
<a href="https://opengrok.libreoffice.org/xref/core/sd/source/ui/func/fupage.cxx#389">https://opengrok.libreoffice.org/xref/core/sd/source/ui/func/fupage.cxx#389</a>.
As observed, it uses mbMasterPage to differentiate between masterpages and not
masterpages... we should do the same in
<a href="https://opengrok.libreoffice.org/xref/core/sd/source/ui/sidebar/SlideBackground.cxx">https://opengrok.libreoffice.org/xref/core/sd/source/ui/sidebar/SlideBackground.cxx</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>