<html> <head> <base href="https://bugs.documentfoundation.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Libreoffice 6.1 base: can't save special options" href="https://bugs.documentfoundation.org/show_bug.cgi?id=119743#c5">Comment # 5</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Libreoffice 6.1 base: can't save special options" href="https://bugs.documentfoundation.org/show_bug.cgi?id=119743">bug 119743</a> from <a class="email" href="mailto:lionel@mamane.lu" title="Lionel Elie Mamane <lionel@mamane.lu>"> Lionel Elie Mamane</a> <pre>It looks like ODbDataSourceAdministrationHelper::fillDatasourceInfo (the function I changed in d6fce54c82868b82bd6fa190db6047d69bbb3ecf) is used not only by the database creation wizard, but also by the "save options" dialog. I missed that when I did that change... (In reply to Julien Nabet from <a href="show_bug.cgi?id=119743#c2">comment #2</a>) > Now about reporter's case and JDBC, I noticed that ParameterNameSubstitution > was in Features part. What about putting it a ParameterNameSubstitution > block in Properties part but with false value by default? In my understanding, any Drivers.xcu file which has a _Feature_ without having the corresponding _Property_ is buggy. According to my understanding of what a Feature is and what a Property is, it makes no sense: * The Feature says "please allow the user to change this setting" * The Property says "this setting is supported by the driver" So yes, I would change all Drivers.xcu files to add (if not already present) the corresponding Property to each entry in Features. This should solve this bug without further code change. There is some complexification of that; for most features the corresponding property has the _same_ _name_. But e.g. the "UseBracketedOuterJoinSyntax" feature corresponds to the "EnableOuterJoinEscape" property! That's the only exception known to me out of the top of my head. Another approach would be to automatically enable the corresponding property of an enabled feature. The current .xcu files seem to have been written in that assumption. It would probably be better backwards-compatible towards external SDBC drivers (that are not bundled with LibreOffice but come e.g. as an extension), but would, I think, be more complicated to do, and leads to less clear and orthogonal semantics of Drivers.xcu files... (In reply to Julien Nabet from <a href="show_bug.cgi?id=119743#c4">comment #4</a>) > Trying to understand all this, I noticed that there are: > "PreferDosLikeLineEnds" and "UseDOSLineEnds" > Shouldn't we have only 1 var? What's the diff between them? > For "ParameterNameSubstitution", I don't see any alternative var. You found a (the?) second exception: The "UseDOSLineEnds" feature corresponds to the "PreferDosLikeLineEnds" property.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>