<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Protecting sheets removes the all cell comments in LibreOffice Calc if the file format had been given as 'xlsx'"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=119190#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Protecting sheets removes the all cell comments in LibreOffice Calc if the file format had been given as 'xlsx'"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=119190">bug 119190</a>
from <span class="vcard"><a class="email" href="mailto:himajin100000@gmail.com" title="himajin100000@gmail.com">himajin100000@gmail.com</a>
</span></b>
<pre><a href="https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/workbookfragment.cxx?r=f87be145#497">https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/workbookfragment.cxx?r=f87be145#497</a>
<a href="https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/worksheethelper.cxx?r=60bc2635#1567">https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/worksheethelper.cxx?r=60bc2635#1567</a>
<a href="https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/worksheethelper.cxx?r=60bc2635#959">https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/worksheethelper.cxx?r=60bc2635#959</a>
<a href="https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/worksheethelper.cxx?r=60bc2635#1328">https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/worksheethelper.cxx?r=60bc2635#1328</a>
<a href="https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/commentsbuffer.cxx?r=3e1d3c25#202">https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/commentsbuffer.cxx?r=3e1d3c25#202</a>
Note:
CommentsFragment, CommentsBuffer , Comment are all different.
Calling importOoxFragment here will not directly trigger
Comment::finalizeImport , but tries to call CommentsFragment::finalizeImport,
which is just the (empty) inherited method(FragmentHandler2::finalizeImport().
So we don't need to worry about the following code.
<a href="https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/worksheetfragment.cxx?r=f87be145#353">https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/worksheetfragment.cxx?r=f87be145#353</a>
****
<a href="https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/workbookfragment.cxx?r=f87be145#437">https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/workbookfragment.cxx?r=f87be145#437</a>
<a href="https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/workbookfragment.cxx?r=f87be145#480">https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/workbookfragment.cxx?r=f87be145#480</a>
<a href="https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/workbookfragment.cxx?r=f87be145#334">https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/workbookfragment.cxx?r=f87be145#334</a>
<a href="https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/workbookfragment.cxx?r=f87be145#256">https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/workbookfragment.cxx?r=f87be145#256</a>
<a href="https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/workbookhelper.cxx?r=fabbeb7a#958">https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/workbookhelper.cxx?r=fabbeb7a#958</a>
<a href="https://opengrok.libreoffice.org/xref/core/oox/source/core/xmlfilterbase.cxx?r=60bc2635#338">https://opengrok.libreoffice.org/xref/core/oox/source/core/xmlfilterbase.cxx?r=60bc2635#338</a>
etc. and the code eventually calls
<a href="https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/worksheetfragment.cxx?r=f87be145#638">https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/worksheetfragment.cxx?r=f87be145#638</a>
<a href="https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/worksheethelper.cxx?r=60bc2635#1562">https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/worksheethelper.cxx?r=60bc2635#1562</a>
<a href="https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/worksheethelper.cxx?r=60bc2635#947">https://opengrok.libreoffice.org/xref/core/sc/source/filter/oox/worksheethelper.cxx?r=60bc2635#947</a>
as importSheetFragments comes before (*aIt)->finalizeDrawingImport() in
WorkbookFragment::finalizeImport(), comment is not added to the protected
sheets.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>