<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:s.mehrbrodt@gmail.com" title="Samuel Mehrbrodt (CIB) <s.mehrbrodt@gmail.com>"> <span class="fn">Samuel Mehrbrodt (CIB)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - LibreOffice remains open in background if it's closed while XML filter settings dialog is open"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=122171">bug 122171</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Keywords</td>
<td>
</td>
<td>difficultyBeginner, easyHack, skillCpp, topicDebug, topicUI
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - LibreOffice remains open in background if it's closed while XML filter settings dialog is open"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=122171#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - LibreOffice remains open in background if it's closed while XML filter settings dialog is open"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=122171">bug 122171</a>
from <span class="vcard"><a class="email" href="mailto:s.mehrbrodt@gmail.com" title="Samuel Mehrbrodt (CIB) <s.mehrbrodt@gmail.com>"> <span class="fn">Samuel Mehrbrodt (CIB)</span></a>
</span></b>
<pre>(In reply to Caolán McNamara from <a href="show_bug.cgi?id=122171#c1">comment #1</a>)
<span class="quote">> I think <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - TerminationVetoException should only prevent termination, not closing windows"
href="show_bug.cgi?id=102288">bug#102288</a> causes this problem. This dialog throws a CloseVeto when
> it has a modal dialog open, but that no longer does what it used to do,
> which was to leave a toplevel window open.</span >
Yes this seems to be caused by my change how TerminationVetoException is
handled.
So instead of throwing a TerminationVetoException, we need to throw a
CloseVetoException here (that would prevent windows from closing).
And we need to listen to XCloseListener::queryClosing instead of
XTerminateListener::queryTermination.
The file is filter/source/xsltdialog/xmlfilterdialogcomponent.cxx .
This change should be quite easy, making an Easy Hack out of it.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>