<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Data Records Not Saved to External Firebird Database File"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=106463#c21">Comment # 21</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Data Records Not Saved to External Firebird Database File"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=106463">bug 106463</a>
from <span class="vcard"><a class="email" href="mailto:lionel@mamane.lu" title="Lionel Elie Mamane <lionel@mamane.lu>"> <span class="fn">Lionel Elie Mamane</span></a>
</span></b>
<pre>(In reply to Drew Jensen from <a href="show_bug.cgi?id=106463#c20">comment #20</a>)
<span class="quote">> Firebird most certainly does support Autocommit and by default.</span >
It seems to me it is definitely not the default at the C API level; one needs
to pass isc_tpb_autocommit as an option. Now, other Firebird UIs or drivers
probably set this option by default :)
<span class="quote">> It must be turned off if you don't want it and the Firebird File
> SDBC does just that and turns it off during the connection process.</span >
Reading the Firebird SDBC code, I discover it already has all the plumbing to
deal with that, but in Driver.cxx:
Reference< XConnection > SAL_CALL FirebirdDriver::connect(...)
{
(...)
if (url == "sdbc:embedded:firebird")
pCon->setAutoCommit(true);
(...)
}
Our documentation
<a href="https://api.libreoffice.org/docs/idl/ref/interfacecom_1_1sun_1_1star_1_1sdbc_1_1XConnection.html#aa6e7212d2813c2b19d99dd1dc9e0ba11">https://api.libreoffice.org/docs/idl/ref/interfacecom_1_1sun_1_1star_1_1sdbc_1_1XConnection.html#aa6e7212d2813c2b19d99dd1dc9e0ba11</a>
clearly says:
By default, new connections are in auto-commit mode.
*But* in Connection.cxx:
Connection::Connection()
(...)
, m_bIsAutoCommit(false)
So, in my opinion this needs to be changed to "true", and the corresponding
lines in Driver.cxx remover as not necessary anymore.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>