<html> <head> <base href="https://bugs.documentfoundation.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Shell function does not work whith .bat files and paths containing spaces" href="https://bugs.documentfoundation.org/show_bug.cgi?id=96038#c13">Comment # 13</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Shell function does not work whith .bat files and paths containing spaces" href="https://bugs.documentfoundation.org/show_bug.cgi?id=96038">bug 96038</a> from <a class="email" href="mailto:todventtu@suomi24.fi" title="Buovjaga <todventtu@suomi24.fi>"> Buovjaga</a> <pre>(In reply to Roland Baudin from <a href="show_bug.cgi?id=96038#c12">comment #12</a>) > (In reply to Buovjaga from <a href="show_bug.cgi?id=96038#c11">comment #11</a>) > > Great, can you submit your patch to gerrit for review? > > <a href="https://wiki.documentfoundation.org/Development/gerrit">https://wiki.documentfoundation.org/Development/gerrit</a> > > > > Please use the master branch for your submission. > > I submitted the patch (in master branch) using gerrit. I hope I did it well > because it was much more complicated than fixing the bug! Yeah, it is a bit of a hurdle :) About your patch, I hope you won't get frustrated, but it would be best, if you changed the first line of the commit message to: <a class="bz_bug_link bz_status_NEW " title="NEW - Shell function does not work whith .bat files and paths containing spaces" href="show_bug.cgi?id=96038">tdf#96038</a> Make shell function work with paths containing spaces You can do it by giving the command git commit --amend and then editing the old message and saving. Then you can just submit the patch again and it will become a new version of the same patch. It matches it up with the help of the "Change-Id" line.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>