<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:vstuart.foote@utsa.edu" title="V Stuart Foote <vstuart.foote@utsa.edu>"> <span class="fn">V Stuart Foote</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Change case -> Sentence case doesn't honor selection; case of entire sentence changes (STR comment 20)"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=49033">bug 49033</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Keywords</td>
<td>
</td>
<td>needsUXEval
</td>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>libreoffice-ux-advise@lists.freedesktop.org
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Change case -> Sentence case doesn't honor selection; case of entire sentence changes (STR comment 20)"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=49033#c45">Comment # 45</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Change case -> Sentence case doesn't honor selection; case of entire sentence changes (STR comment 20)"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=49033">bug 49033</a>
from <span class="vcard"><a class="email" href="mailto:vstuart.foote@utsa.edu" title="V Stuart Foote <vstuart.foote@utsa.edu>"> <span class="fn">V Stuart Foote</span></a>
</span></b>
<pre>To UX-Advise to move this forward...
But my take remains that the original implementation applying the
SENTENCE_CASE, via ICU transliteration, needs additional control logic.
Believe we need to handle two cases for applying SENTENCE_CASE in edit engine
[1].
1) Case -- an active selection made:
expand only to the ICU -word boundaries- that hold the selection and apply
ICU transliteration. Treat that "temp" string as the sentence--and apply
transliteration. Since the transliteration of the selection likely cross
sentence boundaries, would need to break selection into multiple "temp" strings
(an opening, middle(s), a closing)--but honor the selections at the word
boundaries as the range.
2) Case -- only text cursor focus, no selection made:
expand only to the ICU -sentence boundaries- that hold the text cursor and
apply ICU transliteration.
The current implementation for sentence case always performs the expansion when
applying SENTENCE_CASE transliteration, with or without selection--that's the
issue. Current implementation probably could/should be retained for a no
selection case, but need to provide new code for the with selection handling.
=-ref-=
[1]
<a href="https://opengrok.libreoffice.org/xref/core/editeng/source/editeng/impedit4.cxx?r=492ea7e0#2665">https://opengrok.libreoffice.org/xref/core/editeng/source/editeng/impedit4.cxx?r=492ea7e0#2665</a></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>