<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:vmiklos@collabora.com" title="Miklos Vajna <vmiklos@collabora.com>"> <span class="fn">Miklos Vajna</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Sanitize documents using "Find & Replace" getting slower and slower"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=119286">bug 119286</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>vmiklos@collabora.com
</td>
<td>
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Sanitize documents using "Find & Replace" getting slower and slower"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=119286#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Sanitize documents using "Find & Replace" getting slower and slower"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=119286">bug 119286</a>
from <span class="vcard"><a class="email" href="mailto:vmiklos@collabora.com" title="Miklos Vajna <vmiklos@collabora.com>"> <span class="fn">Miklos Vajna</span></a>
</span></b>
<pre>I had a look at this: just reverting the above mentioned commit doesn't change
anything. I get why it doesn't help: the commit changes how documents
containing shapes behave and the bugdoc doesn't have shapes.
I also profiled this: SvxSearchDialog::CommandHdl_Impl() in svx is the UI code,
you can measure the cost of ExecuteSynchron():
- 97% is spent in SwFindParaText::DoFind() (OK)
- 55% of that is sw::ReplaceImpl
- 40% of that is sw::FindTextImpl
- here 20% is the SvxSearchItem ctor, which is already moved out of the
loop for perf reasons
- 18% is DoSearch
So in short, nothing obviously stupid. According to the above numbers, it
indeed smells like a regression, but I doubt it's from the above commit.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>