<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Re-work copy/paste 'orrible extensions dialog code..."
href="https://bugs.documentfoundation.org/show_bug.cgi?id=97102#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Re-work copy/paste 'orrible extensions dialog code..."
href="https://bugs.documentfoundation.org/show_bug.cgi?id=97102">bug 97102</a>
from <span class="vcard"><a class="email" href="mailto:michael.meeks@collabora.com" title="Michael Meeks <michael.meeks@collabora.com>"> <span class="fn">Michael Meeks</span></a>
</span></b>
<pre>Looks like it's still there to me:
//UpdateRequiredDialog
UpdateRequiredDialog::UpdateRequiredDialog(weld::Window *pParent,
TheExtensionManager *pManager)
: GenericDialogController(pParent, "desktop/ui/updaterequireddialog.ui",
"UpdateRequiredDialog")
, DialogHelper(pManager->getContext(), m_xDialog.get())
, m_sCloseText(DpResId(RID_STR_CLOSE_BTN))
, m_bHasProgress(false)
, m_bProgressChanged(false)
, m_bStartProgress(false)
, m_bStopProgress(false)
, m_bHasLockedEntries(false)
, m_nProgress(0)
and
ExtMgrDialog::ExtMgrDialog(weld::Window *pParent, TheExtensionManager
*pManager)
: GenericDialogController(pParent, "desktop/ui/extensionmanager.ui",
"ExtensionManagerDialog")
, DialogHelper(pManager->getContext(), m_xDialog.get())
, m_sAddPackages(DpResId(RID_STR_ADD_PACKAGES))
, m_bHasProgress(false)
, m_bProgressChanged(false)
, m_bStartProgress(false)
, m_bStopProgress(false)
Look too similar. Should be some shared base-class or another helper class for
some of what they want to do with progress.
The idle handlers are still there but didn't read them yet.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>