<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Firebird: XDatabaseMetaData implementation returns NULL strings for DatabaseProductName and DatabaseProductVersion"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=118809#c11">Comment # 11</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Firebird: XDatabaseMetaData implementation returns NULL strings for DatabaseProductName and DatabaseProductVersion"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=118809">bug 118809</a>
from <span class="vcard"><a class="email" href="mailto:serval2412@yahoo.fr" title="Julien Nabet <serval2412@yahoo.fr>"> <span class="fn">Julien Nabet</span></a>
</span></b>
<pre>After my day time job, I'll submit a main patch with 2 suggestions:
"Firebird (engine12)" for getDatabaseProductName
result of "SELECT rdb$get_context('SYSTEM', 'ENGINE_VERSION') as version from
rdb$database" for getDatabaseProductVersion
In a second patch, I'll put
- NumericFunctions
- StringFunctions
- TimeDateFunctions
as suggested
For driver version and name, I thought about lib used by LO.
In master we still use Firebird 3.0.0 (see
<a href="https://opengrok.libreoffice.org/xref/core/download.lst?r=df2b4a9d#48">https://opengrok.libreoffice.org/xref/core/download.lst?r=df2b4a9d#48</a>)
So I'd put:
for getDriverMajorVersion
// Retrieve version from download.lst
return OUString("3.0.0");
for getDriverName:
// Retrieve name from download.lst
Firebird-3.0.0.32483-0.tar.bz2
Also I noticed this:
sal_Int32 SAL_CALL ODatabaseMetaData::getDriverMajorVersion( )
{
return 1;
}
sal_Int32 SAL_CALL ODatabaseMetaData::getDriverMinorVersion( )
{
return 0;
}
See
<a href="https://opengrok.libreoffice.org/xref/core/connectivity/source/drivers/firebird/DatabaseMetaData.cxx?r=1729f554#614">https://opengrok.libreoffice.org/xref/core/connectivity/source/drivers/firebird/DatabaseMetaData.cxx?r=1729f554#614</a>
Shouldn't we put:
sal_Int32 SAL_CALL ODatabaseMetaData::getDriverMajorVersion( )
{
return 3;
}
sal_Int32 SAL_CALL ODatabaseMetaData::getDriverMinorVersion( )
{
return 0;
}
Any thoughts?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>