<html> <head> <base href="https://bugs.documentfoundation.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Insert comment shortcut doesn't let me edit existing comment" href="https://bugs.documentfoundation.org/show_bug.cgi?id=95854#c16">Comment # 16</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Insert comment shortcut doesn't let me edit existing comment" href="https://bugs.documentfoundation.org/show_bug.cgi?id=95854">bug 95854</a> from <a class="email" href="mailto:momonasmon@gmail.com" title="Maxim Monastirsky <momonasmon@gmail.com>"> Maxim Monastirsky</a> <pre>(In reply to Yousuf Philips (jay) (retired) from <a href="show_bug.cgi?id=95854#c9">comment #9</a>) > The same shortcut should work for both inserting and editing comments, as it > used to in 4.4 and below, and as it does in writer, so users dont have to > learn a new shortcut. > > <a href="https://gerrit.libreoffice.org/#/c/31449/">https://gerrit.libreoffice.org/#/c/31449/</a> ^^^ Actually this was a brilliant idea: We can show the same shortcut for two different commands, if only we define the first one in a global scope, and the second one in a module-specific scope (Calc in our case). It is true that the module-specific command is the one that will be always executed by pressing the shortcut, but this isn't a problem here, as both commands share the same execution code. The only remaining problem is that the edit command is disabled when a cell doesn't have a comment, and so can't be executed. But fortunately this can be solved by some sdi magic, so the edit command remains visually disabled, but still can be executed via the api (and thus by a keyboard shortcut). An updated attempt is in gerrit: <a href="https://gerrit.libreoffice.org/c/core/+/90354">https://gerrit.libreoffice.org/c/core/+/90354</a></pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>