<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:serval2412@yahoo.fr" title="Julien Nabet <serval2412@yahoo.fr>"> <span class="fn">Julien Nabet</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Crash: reject/clear formatting"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=131907">bug 131907</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>erack@redhat.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Crash: reject/clear formatting"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=131907#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Crash: reject/clear formatting"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=131907">bug 131907</a>
from <span class="vcard"><a class="email" href="mailto:serval2412@yahoo.fr" title="Julien Nabet <serval2412@yahoo.fr>"> <span class="fn">Julien Nabet</span></a>
</span></b>
<pre>Eike:
I tested this straightforward patch and it worked:
diff --git a/sc/source/core/tool/chgtrack.cxx
b/sc/source/core/tool/chgtrack.cxx
index 0b9f18ec3779..fd720806fc2a 100644
--- a/sc/source/core/tool/chgtrack.cxx
+++ b/sc/source/core/tool/chgtrack.cxx
@@ -4191,8 +4191,7 @@ bool ScChangeTrack::Reject(
bRejected = pAct->Reject( pDoc );
if ( bRejected )
{
- // pRefDoc NULL := Do not save deleted Cells
- AppendDeleteRange( pAct->GetBigRange().MakeRange(), nullptr,
short(0),
+ AppendDeleteRange( pAct->GetBigRange().MakeRange(), pDoc,
short(0),
pAct->GetActionNumber() );
}
}
However, it does the contrary of the comment deleted:
// pRefDoc NULL := Do not save deleted Cells
Git history of this comment gives:
commit 9964dbdda0dd8bb0471a3153ce133a76e98a09b0
Author: Philipp Weissenbacher <<a href="mailto:p.weissenbacher@gmail.com">p.weissenbacher@gmail.com</a>>
Date: Thu Nov 14 12:46:35 2013 +0100
Translate German comments
then:
commit d0484bcdcbffd42d242647a2fdc1a203d176b775
Author: Jens-Heiner Rechtien <<a href="mailto:hr@openoffice.org">hr@openoffice.org</a>>
Date: Mon Sep 18 23:16:46 2000 +0000
initial import
Any thoughts here?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>