<html> <head> <base href="https://bugs.documentfoundation.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_UNCONFIRMED " title="UNCONFIRMED - "!!br0ken!!" is inappropriately used as an IAccessible 2 attribute for cells without formula which breaks formulas detection for assistive technologies." href="https://bugs.documentfoundation.org/show_bug.cgi?id=132147#c4">Comment # 4</a> on <a class="bz_bug_link bz_status_UNCONFIRMED " title="UNCONFIRMED - "!!br0ken!!" is inappropriately used as an IAccessible 2 attribute for cells without formula which breaks formulas detection for assistive technologies." href="https://bugs.documentfoundation.org/show_bug.cgi?id=132147">bug 132147</a> from <a class="email" href="mailto:mikekaganski@hotmail.com" title="Mike Kaganski <mikekaganski@hotmail.com>"> Mike Kaganski</a> <pre>"Regression" after <a href="https://git.libreoffice.org/core/+/ab285c743afa1c8769581871d7b56374fd8c49f1">https://git.libreoffice.org/core/+/ab285c743afa1c8769581871d7b56374fd8c49f1</a> > author Noel Grandin <<a href="mailto:noel.grandin@collabora.co.uk">noel.grandin@collabora.co.uk</a>> Sat Nov 02 18:59:49 2019 +0200 > committer Noel Grandin <<a href="mailto:noel.grandin@collabora.co.uk">noel.grandin@collabora.co.uk</a>> Sun Nov 03 17:11:14 2019 +0100 > > loplugin:stringadd > > tweak the plugin to be more permissive, then validate by hand > afterwards which replaced strFor.replaceAt(0,1,"") with strFor.copy(1). Both methods are illegal on empty string, but the former asserted, then silently corrected wrong count; while the latter returns "br0ken". So the change actually revealed a pre-existing bug. We should likely make the former also result in "br0ken" on invalid input, to allow invalid use cases. This hopefully will be fixed with <a href="https://gerrit.libreoffice.org/c/core/+/92301">https://gerrit.libreoffice.org/c/core/+/92301</a></pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>