<html> <head> <base href="https://bugs.documentfoundation.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Run pyflakes on python uitest files" href="https://bugs.documentfoundation.org/show_bug.cgi?id=132293#c4">Comment # 4</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Run pyflakes on python uitest files" href="https://bugs.documentfoundation.org/show_bug.cgi?id=132293">bug 132293</a> from <a class="email" href="mailto:serval2412@yahoo.fr" title="Julien Nabet <serval2412@yahoo.fr>"> Julien Nabet</a> <pre>When considering the method: 398 def charactersActionForValues(nsNode, refNode): 399 ret = [] 400 401 refName = refNode.getAttribute("name") 402 for defineNode in [i for i in getChildrenByName(getChildByName(nsNode, "grammar"), "define") if defineNode.getAttribute("name") == refName]: 403 ret.append(" {") 404 ret.append(" // %s" % defineNode.getAttribute("name")) 405 for dataNode in getChildrenByName(defineNode, "data"): 406 if dataNode.getAttribute("type") == "int": 407 ret.append(" OOXMLValue::Pointer_t pValue(new OOXMLIntegerValue(sText));") 408 ret.append(" pValueHandler->setValue(pValue);") 409 ret.append(" }") 410 411 return ret (see <a href="https://opengrok.libreoffice.org/xref/core/writerfilter/source/ooxml/factoryimpl_ns.py?r=c4fa6efa#398">https://opengrok.libreoffice.org/xref/core/writerfilter/source/ooxml/factoryimpl_ns.py?r=c4fa6efa#398</a>) since line 402 is wrong, it's quite possible we never enter the loop so the expected code to generate may never be generated. It might be a source of bugs. I insist to tell "it might" since I must recognize I don't really know if it's the case or not. Remark: I'm not sure too that generating C++ code from Python, Perl whatever is a good thing since it's less easy to debug/maintain. IMHO, this part should be converted in C++ but that's another story. I mean I think we shouldn't wait beginners to fix this type of Pyflakes report since it's not just cleaning a double import or removing an unreferenced variable (note that this one can also hide a real bug too). Don't misunderstand me, I understand the goal of Easyhack, to bring newcomers to gain confidence when hacking LO but I think that we shouldn't wait them for some situations.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>