<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - writerfilter/source/ooxml/factoryimpl_ns.py:402: undefined name 'defineNode'"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=132320">132320</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>writerfilter/source/ooxml/factoryimpl_ns.py:402: undefined name 'defineNode'
</td>
</tr>
<tr>
<th>Product</th>
<td>LibreOffice
</td>
</tr>
<tr>
<th>Version</th>
<td>7.0.0.0.alpha0+ Master
</td>
</tr>
<tr>
<th>Hardware</th>
<td>All
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>UNCONFIRMED
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>medium
</td>
</tr>
<tr>
<th>Component</th>
<td>Writer
</td>
</tr>
<tr>
<th>Assignee</th>
<td>libreoffice-bugs@lists.freedesktop.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>xiscofauli@libreoffice.org
</td>
</tr></table>
<p>
<div>
<pre>This is a follow-up of <a class="bz_bug_link
bz_status_NEW "
title="NEW - Run pyflakes on python uitest files"
href="show_bug.cgi?id=132293#c4">bug 132293 comment 4</a>:
When considering the method:
398 def charactersActionForValues(nsNode, refNode):
399 ret = []
400
401 refName = refNode.getAttribute("name")
402 for defineNode in [i for i in
getChildrenByName(getChildByName(nsNode, "grammar"), "define") if
defineNode.getAttribute("name") == refName]:
403 ret.append(" {")
404 ret.append(" // %s" % defineNode.getAttribute("name"))
405 for dataNode in getChildrenByName(defineNode, "data"):
406 if dataNode.getAttribute("type") == "int":
407 ret.append(" OOXMLValue::Pointer_t pValue(new
OOXMLIntegerValue(sText));")
408 ret.append(" pValueHandler->setValue(pValue);")
409 ret.append(" }")
410
411 return ret
(see
<a href="https://opengrok.libreoffice.org/xref/core/writerfilter/source/ooxml/factoryimpl_ns.py?r=c4fa6efa#398">https://opengrok.libreoffice.org/xref/core/writerfilter/source/ooxml/factoryimpl_ns.py?r=c4fa6efa#398</a>)
since line 402 is wrong, it's quite possible we never enter the loop so the
expected code to generate may never be generated.
It might be a source of bugs. I insist to tell "it might" since I must
recognize I don't really know if it's the case or not.
Remark: I'm not sure too that generating C++ code from Python, Perl whatever is
a good thing since it's less easy to debug/maintain. IMHO, this part should be
converted in C++ but that's another story.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>