<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:serval2412@yahoo.fr" title="Julien Nabet <serval2412@yahoo.fr>"> <span class="fn">Julien Nabet</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Wrong quotation mark after a single quote which follows more than 1 letter (eg l'" -> ok, qu'" -> ko)"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=132301">bug 132301</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">See Also</td>
<td>
</td>
<td>https://bugs.documentfoundation.org/show_bug.cgi?id=38394
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Wrong quotation mark after a single quote which follows more than 1 letter (eg l'" -> ok, qu'" -> ko)"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=132301#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Wrong quotation mark after a single quote which follows more than 1 letter (eg l'" -> ok, qu'" -> ko)"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=132301">bug 132301</a>
from <span class="vcard"><a class="email" href="mailto:serval2412@yahoo.fr" title="Julien Nabet <serval2412@yahoo.fr>"> <span class="fn">Julien Nabet</span></a>
</span></b>
<pre>László: noticing
<a href="https://cgit.freedesktop.org/libreoffice/core/commit/?id=8039c9eb27170a162830f0ecd2086010a7a5858f">https://cgit.freedesktop.org/libreoffice/core/commit/?id=8039c9eb27170a162830f0ecd2086010a7a5858f</a>
author László Németh <<a href="mailto:nemeth@numbertext.org">nemeth@numbertext.org</a>> 2019-12-29 12:34:34 +0100
committer László Németh <<a href="mailto:nemeth@numbertext.org">nemeth@numbertext.org</a>> 2019-12-29 16:36:06
+0100
commit 8039c9eb27170a162830f0ecd2086010a7a5858f (patch)
tree d0520fefab6d1dc271ad543115cf210641675545
parent bde382a2568147c1a5eec0cb885856cd5aaae3ad (diff)
<a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - EDITING: Can't insert a French opening quote after an apostrophe using AutoCorrection"
href="show_bug.cgi?id=38394">tdf#38394</a> AutoCorrect: fix ’« in French l’« word »
instead of using the bad ’" -> ’» autocorrection.
Change-Id: I48adbb2e8ca8e786c7835ff186d4580e856cf3c7
Reviewed-on: <a href="https://gerrit.libreoffice.org/c/core/+/85945">https://gerrit.libreoffice.org/c/core/+/85945</a>
Tested-by: Jenkins
Reviewed-by: László Németh <<a href="mailto:nemeth@numbertext.org">nemeth@numbertext.org</a>>
Tested-by: László Németh <<a href="mailto:nemeth@numbertext.org">nemeth@numbertext.org</a>>
Indeed, we enter the block
1297 // <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - EDITING: Can't insert a French opening quote after an apostrophe using AutoCorrection"
href="show_bug.cgi?id=38394">tdf#38394</a> use opening quotation mark << in French l'<<word>>
1298 if ( !bSingle && !bSttQuote && cPrev == cApostrophe &&
1299 (nInsPos == 2 || (nInsPos > 2 && IsWordDelim( rTxt[ nInsPos-3 ] ))) )
1300 {
1301 const LanguageType eLang = GetDocLanguage( rDoc, nInsPos );
1302 if ( primary(eLang) == primary(LANGUAGE_FRENCH) )
1303 bSttQuote = true;
1304 }
(see
<a href="https://opengrok.libreoffice.org/xref/core/editeng/source/misc/svxacorr.cxx?r=c73b9868#1297">https://opengrok.libreoffice.org/xref/core/editeng/source/misc/svxacorr.cxx?r=c73b9868#1297</a>)
thought you might be interested in this one.
I tried this patch and it seems to work. I mean, it works for the case here and
I used "make sw.check", no error.
However, I'd like to have your opinion because I suppose you didn't add this
check for nothing so expect some regression with it.
diff --git a/editeng/source/misc/svxacorr.cxx
b/editeng/source/misc/svxacorr.cxx
index 1242852d6213..6a8d1bbca127 100644
--- a/editeng/source/misc/svxacorr.cxx
+++ b/editeng/source/misc/svxacorr.cxx
@@ -1295,8 +1295,7 @@ void SvxAutoCorrect::DoAutoCorrect( SvxAutoCorrDoc& rDoc,
const OUString& rTxt,
( cEmDash == cPrev ) ||
( cEnDash == cPrev );
// <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - EDITING: Can't insert a French opening quote after an apostrophe using AutoCorrection"
href="show_bug.cgi?id=38394">tdf#38394</a> use opening quotation mark << in French
l'<<word>>
- if ( !bSingle && !bSttQuote && cPrev == cApostrophe &&
- (nInsPos == 2 || (nInsPos > 2 && IsWordDelim( rTxt[
nInsPos-3 ] ))) )
+ if ( !bSingle && !bSttQuote && cPrev == cApostrophe &&
nInsPos >= 2 )
{
const LanguageType eLang = GetDocLanguage( rDoc,
nInsPos );
if ( primary(eLang) == primary(LANGUAGE_FRENCH) )
Any thoughts here?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>