<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Clean up excessive const_cast'ing"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=90341#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Clean up excessive const_cast'ing"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=90341">bug 90341</a>
from <span class="vcard"><a class="email" href="mailto:mesutcifci97@gmail.com" title="mesutcfc <mesutcifci97@gmail.com>"> <span class="fn">mesutcfc</span></a>
</span></b>
<pre>Hi Stephan. I tried fix this issue but jenkins says something went wrong.
This is my patch : <a href="https://gerrit.libreoffice.org/c/core/+/93472">https://gerrit.libreoffice.org/c/core/+/93472</a>
And this is error:
"error "binding value of type "const DbGridControl" to reference to type
"DbGridControl" drops "const" qualifier" triggered in included file
/home/tdf/lode/jenkins/workspace/lo_gerrit/Config/linux_clang_dbgutil_64/svx/source/inc/gridcell.hxx:136:46"
1)I can remove this const keyword
gridcell.hxx:136
DbGridControl& GetParent() const {return m_rParent;}
2)Or i can ignore changes that i made before and only I can change this
function.
std::unique_ptr<DbGridColumn> DbGridControl::CreateColumn(sal_uInt16 nId) const
{
return std::unique_ptr<DbGridColumn>(new DbGridColumn(nId,
*const_cast<DbGridControl*>(this)));
}
with this
std::unique_ptr<DbGridColumn> DbGridControl::CreateColumn(sal_uInt16 nId)
{
return std::unique_ptr<DbGridColumn>(new DbGridColumn(nId, *this));
}
But i'm confused. What the logic in here? One of these ways is right? İf right.
Which and why? I am really curious? Can you help me?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>