<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - Writer comments ruler UI control problems"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=133569">133569</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>Writer comments ruler UI control problems
</td>
</tr>
<tr>
<th>Product</th>
<td>LibreOffice
</td>
</tr>
<tr>
<th>Version</th>
<td>4.1 all versions
</td>
</tr>
<tr>
<th>Hardware</th>
<td>All
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>UNCONFIRMED
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>medium
</td>
</tr>
<tr>
<th>Component</th>
<td>Writer
</td>
</tr>
<tr>
<th>Assignee</th>
<td>libreoffice-bugs@lists.freedesktop.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>glogow@fbihome.de
</td>
</tr></table>
<p>
<div>
<pre>Created <span class=""><a href="http://bugs.documentfoundation.org/attachment.cgi?id=161480" name="attach_161480" title="Dummy document with a comment for easier test">attachment 161480</a> <a href="http://bugs.documentfoundation.org/attachment.cgi?id=161480&action=edit" title="Dummy document with a comment for easier test">[details]</a></span>
Dummy document with a comment for easier test
Original I found that Writer's comments ruler UI control in some KDE theme
setting was highlighting on mouse over to use a black text on black background,
which made it unreadable.
While looking into the code and testing the UI element, I found further
problems with the design and implementation:
* swapping the arrow from left to right, as documented in the design wiki page,
moves the text, which I find highly irritating
* in RTL mode, the label is right-aligned, resulting in completely hidden text
and arrow, if the document space is small
* the arrow has a small, fixed size and padding, drawn with four consecutive
lines, so it doesn't scale in HiDPI mode
Eventually the comments column should switch to the left side of the document,
if the document itself is in RTL mode, as IMHO this follows the reading flow
easier. But since I don't have any experience working with RTL environments, I
didn't implement this.
There is already a patch, which addresses all the mentioned problems:
<a href="https://gerrit.libreoffice.org/c/core/+/75421">https://gerrit.libreoffice.org/c/core/+/75421</a>
Design wiki page:
<a href="https://wiki.documentfoundation.org/Design/Whiteboards/Comments_Ruler_Control">https://wiki.documentfoundation.org/Design/Whiteboards/Comments_Ruler_Control</a>
Implementation tracking: <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Change visibility of comments / notes via Notes Ruler Control [UI] [VIEWING] (OOoNotes2)"
href="show_bug.cgi?id=38246">bug 38246</a>
If some design people have additional comments, I'll try to address them,
otherwise merge the patch end of next week.
To reproduce:
1. Open the attached document
2. Change the comments visibility via the ruler UI element
You can test the HiDPI setting with qt5 / kf5 starting LO with
QT_SCALE_FACTOR=2.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>