<html> <head> <base href="https://bugs.documentfoundation.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_UNCONFIRMED " title="UNCONFIRMED - Image at wrong position after undo and moves to the original position after save & reload" href="https://bugs.documentfoundation.org/show_bug.cgi?id=133655#c4">Comment # 4</a> on <a class="bz_bug_link bz_status_UNCONFIRMED " title="UNCONFIRMED - Image at wrong position after undo and moves to the original position after save & reload" href="https://bugs.documentfoundation.org/show_bug.cgi?id=133655">bug 133655</a> from <a class="email" href="mailto:telesto@surfxs.nl" title="Telesto <telesto@surfxs.nl>"> Telesto</a> <pre>Created <a href="http://bugs.documentfoundation.org/attachment.cgi?id=161616" name="attach_161616" title="Bibisect log">attachment 161616</a> <a href="http://bugs.documentfoundation.org/attachment.cgi?id=161616&action=edit" title="Bibisect log">[details]</a> Bibisect log Bisected to: author Michael Stahl <<a href="mailto:Michael.Stahl@cib.de">Michael.Stahl@cib.de</a>> 2018-08-22 17:09:02 +0200 committer Michael Stahl <<a href="mailto:Michael.Stahl@cib.de">Michael.Stahl@cib.de</a>> 2018-09-19 10:18:29 +0200 commit 723728cd358693b8f4bc9d913541aa4479f2bd48 (patch) tree 1ac75a662a46987301ea85d32957eb08f435ffd6 parent 41d8ca9686c7c184f586e99674b443c34bfd4f33 (diff) sw_redlinehide_2: SwUndoDelete This is problematic because of the calls to SplitNode. Ideally we'd want the SplitNode to create merged frames already, but that doesn't seem to be easy to achieve; several problems with this are: 1. the redlines are only restored at the end of UndoImpl 2. even if we store another set of SwRedlineSaveDatas right before the Join (while preventing the first SwRedlineSaveDatas from deleting them), and restore them by passing a closure to SplitNode, there are complaints about empty redlines, and also this case isn't handled properly: f<delete start>o<redline start>o b<redline end>a<redline start>r b<redline end>a<delete end>z So instead, let SplitNode create whatever frames it does, and fix it up at the end manually on the start node's frames. This necessitates delaying the creation of the frames on the moved nodes until the end too. <a href="https://cgit.freedesktop.org/libreoffice/core/commit/?id=723728cd358693b8f4bc9d913541aa4479f2bd48">https://cgit.freedesktop.org/libreoffice/core/commit/?id=723728cd358693b8f4bc9d913541aa4479f2bd48</a></pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>