<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:dtardon@redhat.com" title="David Tardon <dtardon@redhat.com>"> <span class="fn">David Tardon</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - FORMATTING, FILEOPEN: Spacing above and below paragraph (.lwp)"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=33713">bug 33713</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>dtardon@redhat.com
</td>
</tr>
<tr>
<td style="text-align:right;">Keywords</td>
<td>
</td>
<td>difficultyMedium, easyHack, skillCpp
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - FORMATTING, FILEOPEN: Spacing above and below paragraph (.lwp)"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=33713#c16">Comment # 16</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - FORMATTING, FILEOPEN: Spacing above and below paragraph (.lwp)"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=33713">bug 33713</a>
from <span class="vcard"><a class="email" href="mailto:dtardon@redhat.com" title="David Tardon <dtardon@redhat.com>"> <span class="fn">David Tardon</span></a>
</span></b>
<pre>This shouldn't be hard to do. The relevant information is already parsed, it
just isn't used...
Some high-level info about LWP import code: The code resides in lotuswordpro.
Parsing is two-step, with ODF as an intermediate format, i.e., the parser reads
a LWP document, produces an (internal) ODF document, which is then imported.
The parser itself is in lotuswordpro/source/filter. In general, each concept of
the file format is represented by a separate class, with names starting with
Lwp. ODF export is in lotuswordpro/source/filter/xfilter. In general, there is
a class for each ODF element, but there are some that just group together a
bunch of related arguments (e.g., XFMargins). Class names start with XF or IXF.
The construction of the ODF is done in ToXml() functions.
Now to the task at hand: LwpParaStyle::ApplySpacing() needs to handle
LwpSpacingCommonOverride::SPACING_DYNAMIC (and possibly also SPACING_LEADING)
for abovepara and belowpara. Then the additional info that the margin size is
relative (percentual) needs to be passed through XFParaStyle::SetMargins() down
to XFMargins (Maybe change the SetMargins() arguments to std::variant? That
would also remove the need for a special value meaning "not set".). Finally,
XFMargins::ToXml needs to emit values with a proper unit: either "cm" (the only
possibility now) or "%".</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>