<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:glogow@fbihome.de" title="Jan-Marek Glogowski <glogow@fbihome.de>"> <span class="fn">Jan-Marek Glogowski</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Page size in Writer doesn't show up anymore"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=132172">bug 132172</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>UNCONFIRMED
</td>
<td>NEW
</td>
</tr>
<tr>
<td style="text-align:right;">Ever confirmed</td>
<td>
</td>
<td>1
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Page size in Writer doesn't show up anymore"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=132172#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Page size in Writer doesn't show up anymore"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=132172">bug 132172</a>
from <span class="vcard"><a class="email" href="mailto:glogow@fbihome.de" title="Jan-Marek Glogowski <glogow@fbihome.de>"> <span class="fn">Jan-Marek Glogowski</span></a>
</span></b>
<pre>So I did a bibisect in the 6.4 repo and the bug was introduced by
commit adbd20017ba9ac4cb2e20195f715904d9b11bc17
Author: Jan-Marek Glogowski <<a href="mailto:jan-marek.glogowski@extern.cib.de">jan-marek.glogowski@extern.cib.de</a>>
Date: Mon Nov 25 14:08:44 2019 +0000
<a class="bz_bug_link
bz_status_VERIFIED bz_closed"
title="VERIFIED FIXED - undocked find doesn't get focus on KDE"
href="show_bug.cgi?id=126607">tdf#126607</a> Qt5 activate window before setFocus
On master it was later "fixed" by
commit 3afc718eddcd81232392d46fccc24b8ec626c8df
Author: Caolán McNamara <<a href="mailto:caolanm@redhat.com">caolanm@redhat.com</a>>
Date: Tue Jan 14 10:06:30 2020 +0000
rework PageSizePopup to be a PopupWindowController
So I can just conclude, that the focus handling in the Qt5 VCL is still wrong
:-(
I originally changed
else if ((nFlags & SalFrameToTop::GrabFocus) || (nFlags &
SalFrameToTop::GrabFocusOnly))
- m_pQWidget->setFocus();
+ {
+ pWidget->activateWindow();
+ pWidget->setFocus();
+ }
but maybe the correct focus handling should be:
else if ((nFlags & SalFrameToTop::GrabFocus) || (nFlags &
SalFrameToTop::GrabFocusOnly))
{
- pWidget->activateWindow();
+ if (!(nFlags & SalFrameToTop::GrabFocusOnly))
+ pWidget->activateWindow();
pWidget->setFocus();
}
Problem is, I can't currently test this on master, because the "fix" is not
revertable. And the original <a class="bz_bug_link
bz_status_VERIFIED bz_closed"
title="VERIFIED FIXED - undocked find doesn't get focus on KDE"
href="show_bug.cgi?id=126607">bug 126607</a> doesn't happen anymore, because it
seems like the search toolbar isn't detachable anymore.
Guess I have to free some 30GB for a new 6-4 build to test my assumption...</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>