<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:momonasmon@gmail.com" title="Maxim Monastirsky <momonasmon@gmail.com>"> <span class="fn">Maxim Monastirsky</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - New toolbar button doesn't update the icon after theme change and missing support for extra large icons"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=134887">bug 134887</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Status</td>
<td>UNCONFIRMED
</td>
<td>NEW
</td>
</tr>
<tr>
<td style="text-align:right;">Ever confirmed</td>
<td>
</td>
<td>1
</td>
</tr>
<tr>
<td style="text-align:right;">Summary</td>
<td>Code support for a dedicated extra large (32px*32px) icons in new file
</td>
<td>New toolbar button doesn't update the icon after theme change and missing support for extra large icons
</td>
</tr>
<tr>
<td style="text-align:right;">Keywords</td>
<td>needsUXEval
</td>
<td>
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - New toolbar button doesn't update the icon after theme change and missing support for extra large icons"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=134887#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - New toolbar button doesn't update the icon after theme change and missing support for extra large icons"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=134887">bug 134887</a>
from <span class="vcard"><a class="email" href="mailto:momonasmon@gmail.com" title="Maxim Monastirsky <momonasmon@gmail.com>"> <span class="fn">Maxim Monastirsky</span></a>
</span></b>
<pre>(In reply to Rizal Muttaqin from <a href="show_bug.cgi?id=134887#c0">comment #0</a>)
<span class="quote">> Currently, large (24px*24px) and extra large (32px*32px) icons for creating
> a new file are using the same file so it creates blurry appearance. </span >
True. The code of that button wasn't adapted for the extra large size, see
NewToolbarController::setItemImage.
<span class="quote">> The other things that the icon sometimes turn to a blank page if we change
> the LibreOffice's icon size e.g from Large to Small or change icon theme.
> Luckily this blank page use separate icon. I just question the rationale
> behind.</span >
That's another bug. I fixed similar bugs in other toolbar buttons, but not yet
in this one. This can be fixed by implementing the XSubToolbarController
interface, which makes the button responsible for updating its icon, instead of
the toolbar implementation (which has no idea what was the last selected new
document type).</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>