<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:vmiklos@collabora.com" title="Miklos Vajna <vmiklos@collabora.com>"> <span class="fn">Miklos Vajna</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Saving DOCX to ODT with hiding tracking changes trashes all images"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=135144">bug 135144</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Keywords</td>
<td>regression
</td>
<td>implementationError
</td>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>michael.stahl@cib.de
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Saving DOCX to ODT with hiding tracking changes trashes all images"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=135144#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Saving DOCX to ODT with hiding tracking changes trashes all images"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=135144">bug 135144</a>
from <span class="vcard"><a class="email" href="mailto:vmiklos@collabora.com" title="Miklos Vajna <vmiklos@collabora.com>"> <span class="fn">Miklos Vajna</span></a>
</span></b>
<pre>Now that <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - FILEOPEN: Writer document "Read Error. Format error discovered in the file in sub-document content.xml at 2,68950(row,col).""
href="show_bug.cgi?id=130707">bug 130707</a> is fixed, this is crashing in code introduced in core.git
commit 522ed1b685f5b7eb52efb9d874dfacc02bf82139 (ofz#18563 sw: fix 2 problems
with field marks, 2019-12-06). The immediate problem is:
Thread 1 "soffice.bin" received signal SIGSEGV, Segmentation fault.
0x00007fffcf0fb3fb in sw::CalcBreaks (rBreaks=std::__debug::vector of length 0,
capacity 0, rPam=SwPaM = {...}, isOnlyFieldmarks=false)
at
/home/vmiklos/git/libreoffice/master/sw/source/core/doc/DocumentContentOperationsManager.cxx:561
561
assert(std::get<0>(startedFields.top())->IsCoveringPosition(SwPosition(rTextNode,
i)));
(gdb) print startedFields
$1 = std::stack wrapping: std::__debug::deque with 1 element = {std::tuple
containing = {[1] = 0x0, [2] = false, [3] = 0, [4] = 0}}
I.e. we unconditionally dereference std::get<0>(startedFields.top()), but it's
a nullptr.
Michael Stahl: any idea what's going on here? Should I add a nullptr check
there or is there a deeper problem here?
Steps to reproduce:
1) Open <span class=""><a href="http://bugs.documentfoundation.org/attachment.cgi?id=163550" name="attach_163550" title="Example file (smaller)">attachment 163550</a> <a href="http://bugs.documentfoundation.org/attachment.cgi?id=163550&action=edit" title="Example file (smaller)">[details]</a></span> from this bug.
2) Save as ODT.
3) Open the ODT -> crash.
Sounds like a problem in the recently added CH_TXT_ATR_FIELDSEP feature.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>