<html> <head> <base href="https://bugs.documentfoundation.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - LO 6.4.6.1 and 7.0.1 fail with error 1045 when accessing MySQL database using native connector" href="https://bugs.documentfoundation.org/show_bug.cgi?id=135202#c44">Comment # 44</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - LO 6.4.6.1 and 7.0.1 fail with error 1045 when accessing MySQL database using native connector" href="https://bugs.documentfoundation.org/show_bug.cgi?id=135202">bug 135202</a> from <a class="email" href="mailto:michael.stahl@cib.de" title="Michael Stahl (CIB) <michael.stahl@cib.de>"> Michael Stahl (CIB)</a> <pre>(In reply to Julien Nabet from <a href="show_bug.cgi?id=135202#c43">comment #43</a>) > but should we do this: > - add UnpackedTarball/mariadb-connector-c/libmariadb/secure/openssl_crypt in > external/mariadb-connector-c/StaticLibrary_mariadb-connector-c.mk ... and win_crypt.c for windows. > - add "#define WIN32 1" in > external/mariadb-connector-c/configs/wnt_ma_config.h this should be unnecessary, i mostly see _WIN32 being checked, and WIN32 is only around <dlfcn.h> but why would anything need that on windows? > - add "#define HAVE_OPENSSL 1" in > external/mariadb-connector-c/configs/linux_my_config.h and mac_my_config.h > ? > since sha2 needs cryptographic libs. > At least it builds locally (pc Debian x86-64 with master sources updated > today, but can't really test since I use MariaDB not MySQL) > > MariaDB proposes gnutls but it seems we use more often openssl yes this sounds reasonable, we can't use gnutls as it's not in external/. also need this: $(eval $(call gb_StaticLibrary_use_external,mariadb-connector-c,openssl)) oh, and it also needs adding to EXTERNAL_PLUGINS and BUILTIN_PLUGINS in UnpackedTarball_mariadb-connector-c.mk ... the "caching_sha2_password_client_plugin", presumably...</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>