<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:jluth@mail.com" title="Justin L <jluth@mail.com>"> <span class="fn">Justin L</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Clicking behind a sentence ending in a commented word places cursor before final period"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=120290">bug 120290</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #148844 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Clicking behind a sentence ending in a commented word places cursor before final period"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=120290#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Clicking behind a sentence ending in a commented word places cursor before final period"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=120290">bug 120290</a>
from <span class="vcard"><a class="email" href="mailto:jluth@mail.com" title="Justin L <jluth@mail.com>"> <span class="fn">Justin L</span></a>
</span></b>
<pre>Created <span class=""><a href="http://bugs.documentfoundation.org/attachment.cgi?id=167239" name="attach_167239" title="comment.odt: tweaked to test the thinest character (|), and multi-comments.">attachment 167239</a> <a href="http://bugs.documentfoundation.org/attachment.cgi?id=167239&action=edit" title="comment.odt: tweaked to test the thinest character (|), and multi-comments.">[details]</a></span>
comment.odt: tweaked to test the thinest character (|), and multi-comments.
Miklos cautiously handled a similar issue in
<a href="https://cgit.freedesktop.org/libreoffice/core/commit/?id=27c46ecf34b32bae1806d3fc0e1684179301feb8">https://cgit.freedesktop.org/libreoffice/core/commit/?id=27c46ecf34b32bae1806d3fc0e1684179301feb8</a>
for comments after flies. I guess in theory it could be extended for any
portion with width zero.
Handling a comment (or other zero width portions) at the very end of the line
can be accomplished with:
if (nWidth30 >= nX && (!pPor->IsFlyCntPortion() ||
!pPor->GetNextPortion()->IsPostItsPortion()))
- return false;
+ return nWidth30 == nX && !pPor->GetNextPortion()->Width();
But who knows what all portions can have zero width, and that could have a LOT
of unintended consequences. Also, this routine is called every time the cursor
quivers - so tight coding is very important.
Proposed fix:
<a href="https://gerrit.libreoffice.org/c/core/+/105746">https://gerrit.libreoffice.org/c/core/+/105746</a> <a class="bz_bug_link
bz_status_NEW "
title="NEW - Clicking behind a sentence ending in a commented word places cursor before final period"
href="show_bug.cgi?id=120290">tdf120290</a> sw: move cursor behind
comment at line end
<a href="https://gerrit.libreoffice.org/c/core/+/105747">https://gerrit.libreoffice.org/c/core/+/105747</a> <a class="bz_bug_link
bz_status_NEW "
title="NEW - Clicking behind a sentence ending in a commented word places cursor before final period"
href="show_bug.cgi?id=120290">tdf#120290</a> sw: comment no longer
needs any width</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>