<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:sbergman@redhat.com" title="Stephan Bergmann <sbergman@redhat.com>"> <span class="fn">Stephan Bergmann</span></a>
</span> changed
<a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - LibreOffice doesn't preserve facls (create new files on save and ignores old facls)"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=138252">bug 138252</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>sbergman@redhat.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - LibreOffice doesn't preserve facls (create new files on save and ignores old facls)"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=138252#c1">Comment # 1</a>
on <a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - LibreOffice doesn't preserve facls (create new files on save and ignores old facls)"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=138252">bug 138252</a>
from <span class="vcard"><a class="email" href="mailto:sbergman@redhat.com" title="Stephan Bergmann <sbergman@redhat.com>"> <span class="fn">Stephan Bergmann</span></a>
</span></b>
<pre>capturing the recent discussion on FreeNode #libreoffice-dev:
<span class="quote">> Nov 17 14:52:36 <sberg_> vmiklos, I tend to remember you once added code (in sfx2 or similar) to preserve certain attributes of the original file when a new version of a document is saved, similar to how <a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - LibreOffice doesn't preserve facls (create new files on save and ignores old facls)"
href="show_bug.cgi?id=138252">tdf#138252</a> now asks for extended ACLs to be preserved on Linux?
> Nov 17 14:52:38 <IZBot> LibreOffice-Calc normal/medium UNCONFIRMED LibreOffice doesn't preserve facls (create new files on save and ignores old facls) <a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - LibreOffice doesn't preserve facls (create new files on save and ignores old facls)"
href="show_bug.cgi?id=138252">https://bugs.documentfoundation.org/show_bug.cgi?id=138252</a>
> Nov 17 14:54:39 <vmiklos> sberg_: IsFileMovable() in sfx2/source/doc/docfile.cxx this to decide if we can move the tmp file to the final destination or we have to copy the bytes over
> Nov 17 14:55:43 <vmiklos> osl::File::replace() is what it uses, which is just a plain rename() in the linux case, there is some better "replace and inherit the destination properties" api on windows.
> Nov 17 14:57:06 <sberg_> vmiklos, I think I'd thought of something else (a place that copies the Unix user/group/other permission bits, say), but I may well misremember anyway
> Nov 17 14:58:12 <vmiklos> sberg_: that GetDefaultFileAttributes() + osl::File::setAttributes() at the same place where IsFileMovable() gets called?
> Nov 17 14:58:13 <sberg_> vmiklos, ah, that "// Adjust attributes" stuff later in that file...
> Nov 17 14:58:23 <sberg_> yeah :)
> Nov 17 14:59:12 <vmiklos> i don't have a strong opinion on that file moving, it's possible we should just give up on this on linux, and make it windows-only, where we have a good api to replace content..
> Nov 17 15:00:13 <noelgrandin> I thought I saw something on the kernel mailing list about one of the filesystems implementing this kind of thing
> Nov 17 15:01:19 <sberg_> vmiklos, benefit is probably that it makes it harder to get a file truncated in the middle if things go wrong midway
> Nov 17 15:02:38 <noelgrandin> those of us with flakey power thank the people who implement such things
> Nov 17 15:03:27 <vmiklos> sberg_: yes, i though this is really standard way of doing things, but then people complained about all sort of corner-cases :) so now i'm less sure this was a good idea after all.</span ></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>