<html> <head> <base href="https://bugs.documentfoundation.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - Drop redundant asserts after MacrosTest::loadFromDesktop" href="https://bugs.documentfoundation.org/show_bug.cgi?id=139734#c2">Comment # 2</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - Drop redundant asserts after MacrosTest::loadFromDesktop" href="https://bugs.documentfoundation.org/show_bug.cgi?id=139734">bug 139734</a> from <a class="email" href="mailto:moaz.eldefrawy@gmail.com" title="Moaz El-defrawy <moaz.eldefrawy@gmail.com>"> Moaz El-defrawy</a> <pre>(In reply to Mike Kaganski from <a href="show_bug.cgi?id=139734#c0">comment #0</a>) > In many unit tests (e.g., in dbaccess/qa/extras/empty-stdlib-save.cxx), we > have this pattern asserting on return value of MacrosTest::loadFromDesktop: > > > uno::Reference<lang::XComponent> xComponent = loadFromDesktop(aFileName); > > CPPUNIT_ASSERT(xComponent.is()); > > MacrosTest::loadFromDesktop itself asserts on its return value (see [1]). > Thus, there additional checks in unit tests are redundant, and only create > noise unrelated to the tested functionality. > > This easy hack is about finding all the places where the method is used, and > removing the direct assert on its return value if present. > > [1] > <a href="https://opengrok.libreoffice.org/xref/core/unotest/source/cpp/macros_test">https://opengrok.libreoffice.org/xref/core/unotest/source/cpp/macros_test</a>. > cxx?r=042033f1&mo=984&fi=39#39 Hey, can I work on this? (Sorry, for making the comment twice. still getting used to the UI)</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>