<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Drop redundant asserts after MacrosTest::loadFromDesktop"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=139734#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Drop redundant asserts after MacrosTest::loadFromDesktop"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=139734">bug 139734</a>
from <span class="vcard"><a class="email" href="mailto:moaz.eldefrawy@gmail.com" title="Moaz El-defrawy <moaz.eldefrawy@gmail.com>"> <span class="fn">Moaz El-defrawy</span></a>
</span></b>
<pre>(In reply to Mike Kaganski from <a href="show_bug.cgi?id=139734#c5">comment #5</a>)
<span class="quote">> (In reply to Moaz El-defrawy from <a href="show_bug.cgi?id=139734#c4">comment #4</a>)
> > Update: I am removed 99% of the redundant asserts and I will submit a patch
> > very soon.
>
> Very good!
>
> > I had a question though:
> > There is a pattern of asserting the return values of many functions not just
> > "loadFromDesktop". Why don't we assert their return values instead just like
> > "loadFromDesktop" and remove the extra ones?
>
> This needs discussing case-by-case. In this form, I can't answer this. Which
> specific change(s) you propose?</span >
I was thinking about it as a general principle and not about specific changes.
but, I just realized you I am incorrect. For example, what if we want the
function to return 0 or null at some cases.
<span class="quote">>
> > another question:
> > I am not sure how style the comments to make them more readable. I tried
> > html and readme files styling but neither worked.
>
> Are you talking about commit message, or about some comments in code? It's
> best to discuss in Gerrit change, where you post some proposed change, and
> then comment on parts that you are unsure with, and get responses from
> reviewers.</span >
I am sorry for not being clear enough. I was asking if there is a way to style
the comments here (in this page) in case I wanted to insert some code. it seems
like '>' character is the only way to do that?
<span class="quote">>
> Looking forward to see the change on Gerrit. Thanks for working on this!</span >
Thanks a lot. I am excited to finish it and move on to the next issue.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>