<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:jluth@mail.com" title="Justin L <jluth@mail.com>"> <span class="fn">Justin L</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - FILESAVE DOCX Don’t add space between paragraphs of the same style not overridden"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=134385">bug 134385</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Keywords</td>
<td>bibisectRequest
</td>
<td>bibisected, bisected
</td>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>jluth@mail.com, kendy@collabora.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - FILESAVE DOCX Don’t add space between paragraphs of the same style not overridden"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=134385#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - FILESAVE DOCX Don’t add space between paragraphs of the same style not overridden"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=134385">bug 134385</a>
from <span class="vcard"><a class="email" href="mailto:jluth@mail.com" title="Justin L <jluth@mail.com>"> <span class="fn">Justin L</span></a>
</span></b>
<pre>repro 7.2. Also true for .doc and .rtf formats.
I bibisected this to 6.0 IMPORT patch:
commit f8b5ecc622e2b3e82576b27bf0ded9c8eac21cae
Author: Miklos Vajna on Oct 24 09:27:19 2017 +0200
<a class="bz_bug_link
bz_status_VERIFIED bz_closed"
title="VERIFIED FIXED - FILEOPEN: RTF: Incorrect vertical position of last bullet of the list"
href="show_bug.cgi?id=113202">tdf#113202</a> RTF import: fix lack of expected contextual spacing
HOWEVER, I wasn't comparing with MS Word. MS Word 2016 also does display any
spacing. So actually this 6.0 bibisect is a fix.
So, if I bibisect using MS Word 2016 as the verifier, then I confirm NISZ's
conclusion that it was in broken at LO 4.2 with:
commit 33e97347ac5b1a3206ddcc2c8313c7e88461bb0b
Author: Jan Holesovsky on Oct 9 14:39:35 2013 +0200
DOCX export: Write contextualSpacing only if it takes place.
<a href="https://cgit.freedesktop.org/libreoffice/core/commit/?id=33e97347ac5b1a3206ddcc2c8313c7e88461bb0b">https://cgit.freedesktop.org/libreoffice/core/commit/?id=33e97347ac5b1a3206ddcc2c8313c7e88461bb0b</a>
So the fix here will be to see if it inherits contextualspacing == true, and in
that case write out a false. (see
<a href="https://gerrit.libreoffice.org/c/core/+/106315">https://gerrit.libreoffice.org/c/core/+/106315</a> for a similar case for character
properties.)
P.S. At this point, MSWord shows RTF with no spacing - same as with 7.2.
However, DOC has spacing between every single one of the first five paragraphs
(which was mysteriously fixed shortly thereafter in the range
<a href="https://cgit.freedesktop.org/libreoffice/core/log/?id=33e97347ac5b1a3206ddcc2c8313c7e88461bb0b&qt=range&q=ff3b823ef4b867263711703fab596584314e4f58..fdba797bd9c2a3fe4de82f92c3ee815c15f8ac84">https://cgit.freedesktop.org/libreoffice/core/log/?id=33e97347ac5b1a3206ddcc2c8313c7e88461bb0b&qt=range&q=ff3b823ef4b867263711703fab596584314e4f58..fdba797bd9c2a3fe4de82f92c3ee815c15f8ac84</a>)</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>