<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Text runs of RTL scripts (e.g. Arabic, Hebrew, Persian) from imported PDF are reversed, PDFIProcessor::mirrorString not behaving"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=104597#c53">Comment # 53</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Text runs of RTL scripts (e.g. Arabic, Hebrew, Persian) from imported PDF are reversed, PDFIProcessor::mirrorString not behaving"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=104597">bug 104597</a>
from <span class="vcard"><a class="email" href="mailto:suokunlong@126.com" title="Kevin Suo <suokunlong@126.com>"> <span class="fn">Kevin Suo</span></a>
</span></b>
<pre>Created <span class=""><a href="https://bugs.documentfoundation.org/attachment.cgi?id=173616" name="attach_173616" title="tdf104597-not-perfect-patch.diff">attachment 173616</a> <a href="https://bugs.documentfoundation.org/attachment.cgi?id=173616&action=edit" title="tdf104597-not-perfect-patch.diff">[details]</a></span>
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Text runs of RTL scripts (e.g. Arabic, Hebrew, Persian) from imported PDF are reversed, PDFIProcessor::mirrorString not behaving"
href="show_bug.cgi?id=104597">tdf104597</a>-not-perfect-patch.diff
Good news is that we are almost there.
With the attached modification to the code, the RTL text are now shown in
correct order.
However, the modification has deleted the "(rCurGC.Transformation ==
rNextGC.Transformation || notTransformed(rNextGC))" condition directly. This
may be wrong. Need to find a special case when some text within a line has
transformation even though the characters in this line all have the same font
id and the same fill color. This may be very rare. I tested many PDFs with this
patch applied on current master, all of them are displaying perfect.
As a result, the attached may be committed to master in my opinion, because
this makes Draw to be usable for RTL pdf files. In case someone find a special
case when the removable of transformation may have caused a regression, then we
investigate that matter separately.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>