<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:serval2412@yahoo.fr" title="Julien Nabet <serval2412@yahoo.fr>"> <span class="fn">Julien Nabet</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Draw Spanish UI does not distinguish two buttons for 3D objects"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=142823">bug 142823</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>rb.henschel@t-online.de
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Draw Spanish UI does not distinguish two buttons for 3D objects"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=142823#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Draw Spanish UI does not distinguish two buttons for 3D objects"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=142823">bug 142823</a>
from <span class="vcard"><a class="email" href="mailto:serval2412@yahoo.fr" title="Julien Nabet <serval2412@yahoo.fr>"> <span class="fn">Julien Nabet</span></a>
</span></b>
<pre>Regina: the bug is about these 2 uno functions:
- uno:ConvertInto3DLatheFast -> "To 3D ~Rotation Object"
SID_CONVERT_TO_3D_LATHE_FAST
- uno:ConvertInto3DLathe -> "In 3D Rotation Object"
SID_CONVERT_TO_3D_LATHE
Searching about SID_CONVERT_TO_3D_LATHE_FAST, I see in
sd/source/ui/view/drviews2.cxx:
3377 case SID_CONVERT_TO_3D_LATHE_FAST:
3378 {
3379 /* The call is enough. The initialization via
Start3DCreation and
3380 CreateMirrorPolygons is no longer needed if the
parameter
3381 sal_True is provided. Then a tilted rotary body with an
axis left
3382 besides the bounding rectangle of the selected objects
is drawn
3383 immediately and without user interaction. */
3384 mpDrawView->SdrEndTextEdit();
3385 if(GetActiveWindow())
3386 GetActiveWindow()->EnterWait();
3387 mpDrawView->End3DCreation(true);
3388 Cancel();
3389 rReq.Ignore();
3390 if(GetActiveWindow())
3391 GetActiveWindow()->LeaveWait();
3392 }
See
<a href="https://opengrok.libreoffice.org/xref/core/sd/source/ui/view/drviews2.cxx?r=b1668edf#3377">https://opengrok.libreoffice.org/xref/core/sd/source/ui/view/drviews2.cxx?r=b1668edf#3377</a>
Searching about SID_CONVERT_TO_3D_LATHE, I see in sd/source/ui/func/fusel.cxx:
1127 case SID_CONVERT_TO_3D_LATHE:
1128 {
1129 eMode = SdrDragMode::Mirror;
1130 bSuppressChangesOfSelection = true;
1131
1132 if ( mpView->GetDragMode() != eMode )
1133 mpView->SetDragMode(eMode);
1134
1135 if (!mpView->Is3DRotationCreationActive())
1136 mpView->Start3DCreation();
1137
1138 bSuppressChangesOfSelection = false;
1139 }
see
<a href="https://opengrok.libreoffice.org/xref/core/sd/source/ui/func/fusel.cxx?r=bfc1600c#1127">https://opengrok.libreoffice.org/xref/core/sd/source/ui/func/fusel.cxx?r=bfc1600c#1127</a>
As if SID_CONVERT_TO_3D_LATHE was to start 3D creation and
SID_CONVERT_TO_3D_LATHE was to end 3D creation
If yes, why aren't they named:
SID_CONVERT_TO_3D_BEGIN/uno:ConvertInto3DBegin and
SID_CONVERT_TO_3D_END/uno:ConvertInto3DEnd
?
I suppose I must have missed something.
Any thoughts here?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>