<html>
<head>
<base href="https://bugs.documentfoundation.org/">
</head>
<body><span class="vcard"><a class="email" href="mailto:l.lunak@collabora.com" title="Luboš Luňák <l.lunak@collabora.com>"> <span class="fn">Luboš Luňák</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - FILEOPEN: Spreadsheet takes long to open"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=130795">bug 130795</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>l.lunak@collabora.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - FILEOPEN: Spreadsheet takes long to open"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=130795#c21">Comment # 21</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - FILEOPEN: Spreadsheet takes long to open"
href="https://bugs.documentfoundation.org/show_bug.cgi?id=130795">bug 130795</a>
from <span class="vcard"><a class="email" href="mailto:l.lunak@collabora.com" title="Luboš Luňák <l.lunak@collabora.com>"> <span class="fn">Luboš Luňák</span></a>
</span></b>
<pre>The real problem here is not that SharedStringPool would be slow, but that
ScTable::ValidQuery()/QueryEvaluator calls it at all. If you look at how it's
used, those strings are interned only to do a "fast" case-insensitive
comparison _once_, but interning a string apparently takes way longer than a
normal comparison would. The concurrent hashmap change is band-aid (at least in
this case), the real fix should be removing the SharedStringPool usage from
QueryEvaluator. <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Deleting 10.000 rows column in a spreadsheet: 15 sec with 4.1| 10 sec up to 300+ sec with 6.2| 130 sec with 7.3"
href="show_bug.cgi?id=144249">Bug #144249</a> has a similar problem.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>